[LINTER] Set the rules for the phpdoc comments
ClosedPublic
Actions

Authored by Fabien on Jun 14 2019, 15:05.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGbaca373a81a8: [LINTER] Set the rules for the phpdoc comments
rABCbaca373a81a8: [LINTER] Set the rules for the phpdoc comments

Summary

The rules are currently the phpcs default. This diff disables some of
them which will cause the arcanist doc comments to throw errors.

Test Plan

arc lint -- arcanist/linter/*

Diff Detail

Repository

rABC Bitcoin ABC

Branch

phpcs_doccomment_rules

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6342
Build 10731: Bitcoin ABC Buildbot (legacy)
Build 10730: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 14 2019, 15:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2019, 15:05

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6342: Diff 9442.Jun 14 2019, 15:14

Fabien added a child revision: D3335: [LINTER] Make the check-doc linter run only once.Jun 14 2019, 15:16

deadalnix accepted this revision.Jun 15 2019, 21:01

This revision is now accepted and ready to land.Jun 15 2019, 21:01

Closed by commit rABCbaca373a81a8: [LINTER] Set the rules for the phpdoc comments (authored by Fabien). · Explain WhyJun 17 2019, 11:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCbaca373a81a8: [LINTER] Set the rules for the phpdoc comments.

Fabien added a commit: rSTAGINGbaca373a81a8: [LINTER] Set the rules for the phpdoc comments.Sep 19 2019, 00:21

Revision Contents
Changeset List

Path

Size

test/

lint/

phpcs/

bitcoinabc_ruleset.xml

4 lines

Diff 9442

View Options

test/lint/phpcs/bitcoinabc_ruleset.xml

[LINTER] Set the rules for the phpdoc commentsClosedPublicActions