Page MenuHomePhabricator
Differential D3343

[refactor] Make TransactionWithinChainLimit more flexible
ClosedPublic
Actions

Authored by deadalnix on Jun 14 2019, 21:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING04dacad3085c: [refactor] Make TransactionWithinChainLimit more flexible
rABC04dacad3085c: [refactor] Make TransactionWithinChainLimit more flexible
Summary
  • Add GetTransactionAncestry to CTxMemPool for general purpose chain limit checking
  • Switch to GetTransactionAncestry() in OutputEligibleForSpending
  • Remove deprecated TransactionWithinChainLimit
  • wallet: Strictly greater than for ancestor caps
  • wallet: Switch to using ancestor/descendant limits

Instead of combining the -limitancestorcount and -limitdescendantcount into a nMaxChainLength, this commit uses each one separately in the coin eligibility filters.

  • test: Add MempoolAncestryTests

This is a backport of Core PR12634

Depends on D3336 and D3342

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 14 2019, 21:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2019, 21:26
teamcity added a comment.Jun 14 2019, 21:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 14 2019, 21:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6356: Diff 9460.Jun 14 2019, 21:36
Fabien requested changes to this revision.Jun 17 2019, 07:07
Fabien mentioned this in D3342: Use mempool's descendent count in the wallet code.
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/mempool_tests.cpp
913 ↗(On Diff #9460)

GetHash() => GetId() everywhere

916 ↗(On Diff #9460)

Dito, see comment in D3342.

This revision now requires changes to proceed.Jun 17 2019, 07:09
deadalnix updated this revision to Diff 9525.Jun 18 2019, 23:19

GetHash => GetId

teamcity added a comment.Jun 18 2019, 23:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 18 2019, 23:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6395: Diff 9525.Jun 18 2019, 23:29
Fabien accepted this revision.Jun 19 2019, 06:05
This revision is now accepted and ready to land.Jun 19 2019, 06:05
Closed by commit rABC04dacad3085c: [refactor] Make TransactionWithinChainLimit more flexible (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by deadalnix). · Explain WhyJun 19 2019, 12:39
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC04dacad3085c: [refactor] Make TransactionWithinChainLimit more flexible.
deadalnix added a commit: rSTAGING04dacad3085c: [refactor] Make TransactionWithinChainLimit more flexible.Sep 19 2019, 00:24

Revision Contents
Changeset List

PathSize
src/
test/
187 lines
8 lines
13 lines
wallet/
32 lines

Diff 9533

View Options

src/test/mempool_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...