Page MenuHomePhabricator
Differential D3437

Add unit tests for signals generated by ProcessNewBlock()
ClosedPublic
Actions

Authored by deadalnix on Jun 27 2019, 16:48.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING5be0cb874c80: Add unit tests for signals generated by ProcessNewBlock()
rABC5be0cb874c80: Add unit tests for signals generated by ProcessNewBlock()
Summary

After a recent bug discovered in callback ordering in MainSignals,
this test checks invariants in ordering of
BlockConnected / BlockDisconnected / UpdatedChainTip signals

This is a partial backport of Core PR13023 : https://github.com/bitcoin/bitcoin/pull/13023/commits/dd435ad40267f5c50ff17533c696f9302829a6a6

Depends on D3436

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13023
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6509
Build 11065: Bitcoin ABC Buildbot (legacy)
Build 11064: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 27 2019, 16:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2019, 16:48
teamcity added a comment.Jun 27 2019, 16:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6509: Diff 9719.Jun 27 2019, 16:57
teamcity added a comment.Jun 27 2019, 16:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D3450: Make unit tests use the insecure_rand_ctx exclusively.Jun 28 2019, 00:06
deadalnix updated this revision to Diff 9764.Jun 28 2019, 14:16

rebase

teamcity added a comment.Jun 28 2019, 14:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6535: Diff 9764.Jun 28 2019, 14:29
teamcity added a comment.Jun 28 2019, 14:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jun 28 2019, 16:55
This revision is now accepted and ready to land.Jun 28 2019, 16:55
Closed by commit rABC5be0cb874c80: Add unit tests for signals generated by ProcessNewBlock() (authored by Jesse Cohen <jc@jc.lol>, committed by deadalnix). · Explain WhyJun 29 2019, 21:21
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC5be0cb874c80: Add unit tests for signals generated by ProcessNewBlock().
deadalnix added a commit: rSTAGING5be0cb874c80: Add unit tests for signals generated by ProcessNewBlock().Sep 19 2019, 00:44

Revision Contents
Changeset List

Diff 9719

View Options

src/Makefile.test.include

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/test_bitcoin.h

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/test/validation_block_tests.cpp

Loading...