Fixed FreeBSD build instructions (by Candunc)
ClosedPublic
Actions

Authored by freetrader on Jul 15 2017, 02:04.

Details

Reviewers

Unknown Object (User)
deadalnix

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGddc452a49573: Fixed FreeBSD build instructions (by Candunc)
rABCddc452a49573: Fixed FreeBSD build instructions (by Candunc)

Summary

Documentation fixes for building Bitcoin ABC on FreeBSD (non-GUI version only at the moment)

Test Plan

Verify that the instructions result in a working build on FreeBSD 11.0-RELEASE

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Unknown Object (User) created this revision.Jul 15 2017, 02:04

Owners added a reviewer: Restricted Owners Package.Jul 15 2017, 02:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2017, 02:04

I tested both wallet and non-wallet build according to these instructions on an 11.0-RELEASE-p10 , with gmake check passing .

I need to upgrade the VM before I can attempt to run regression tests.

freetrader requested changes to this revision.Jul 18 2017, 10:22

freetrader added inline comments.

doc/build-unix.md
323 ↗	(On Diff #833)	I found that I needed to add 'db5' as a dependent package (this was on a clean install of 11-RELEASE). An optional dependency, if a user wishes to run the regression test, is the 'python3' package. Could I ask you to add this information?

This revision now requires changes to proceed.Jul 18 2017, 10:22

Yes, I can add this information. Also, regarding the GitHub comment "P.S. I'm interested - do you know what it would take to flesh this out to include a GUI build ?", I can look into that.

In D332#5765, @Candunc wrote:

Yes, I can add this information.

Much appreciated!

Also, regarding the GitHub comment "P.S. I'm interested - do you know what it would take to flesh this out to include a GUI build ?", I can look into that.

Let's do that in a follow-up Diff. More important to get the basic instruction update in first.
Thank you for looking into it, it would be nice if we can get that to work.

Good news on the testing front.

I updated my FreeBSD 11 VM, and built 5dba98f , ran the unit tests successfully and the applicable (*) qa tests also passed.

(*) rpcbind_test.py is Linux only, and fails. The test framework in Core needs to be improved in a similar way that I did on BU, to not run tests which are platform-specific on the wrong platforms .

Apart from that, the changes look good - just needs a minor update for the db5 and python3 packages, and then we could update these instructions.

Then the GUI instructions (if it works out) could be added in another patch.