Page MenuHomePhabricator

freetrader (freetrader)
User

Projects

User does not belong to any projects.

User Details

User Since
May 19 2017, 09:15 (82 w, 23 h)

Recent Activity

Dec 6 2017

freetrader accepted D760: Reenable several disabled warnings.
Dec 6 2017, 16:53

Dec 4 2017

freetrader added inline comments to D750: Add developer guide to CONTRIBUTING.md.
Dec 4 2017, 19:56
freetrader added inline comments to D738: Update the chain paramaters..
Dec 4 2017, 03:31
freetrader added a comment to D736: Activate the new DAA by height instead of MTP..

When the median time past[1] of the most recent 11 blocks (MTP-11) is greater than or equal to UNIX timestamp 1510600000 Bitcoin Cash will execute a hardfork according to this specification. Starting from the next block these three consensus rules changes will take effect:
...

Dec 4 2017, 00:38

Nov 29 2017

freetrader accepted D552: Support cashaddr in Qt input validation.

LGTM, tested ok.

Nov 29 2017, 18:26

Nov 23 2017

freetrader committed rABCb8923939fe05: Do not require NODE_BITCOIN_CASH (fix IBD) (authored by freetrader).
Do not require NODE_BITCOIN_CASH (fix IBD)
Nov 23 2017, 21:39
freetrader closed D710: Do not require NODE_BITCOIN_CASH (fix IBD).
Nov 23 2017, 21:39
Herald added 1 blocking reviewer(s) for D710: Do not require NODE_BITCOIN_CASH (fix IBD): Restricted Project.
Nov 23 2017, 21:11

Nov 16 2017

freetrader accepted D553: Make DummyAddress support cashaddr.
Nov 16 2017, 01:34

Nov 15 2017

freetrader accepted D648: Update developer notes to include Arcanist setup instructions.
Nov 15 2017, 23:41
freetrader requested changes to D696: Update bug report template for github.
Nov 15 2017, 23:39
freetrader accepted D683: Add flag to enable dst encoding using cashaddr.

LGTM, tests ok

Nov 15 2017, 14:20
freetrader committed rABC885bc8c0807b: Remove the redundant namespace closing brace (authored by freetrader).
Remove the redundant namespace closing brace
Nov 15 2017, 03:50
freetrader closed D684: Remove the redundant namespace closing brace.
Nov 15 2017, 03:50
Herald added 1 blocking reviewer(s) for D684: Remove the redundant namespace closing brace: Restricted Project.
Nov 15 2017, 03:26

Nov 10 2017

freetrader requested changes to D657: BCC -> BCH.

See previous comments for list of BCC occurrences that I think should be added.

Nov 10 2017, 04:03
freetrader added a comment to D657: BCC -> BCH.

I applied this diff to HEAD, and used a grep program to scan for more BCC. Found some which maybe you can still replace together with those you have already in this Diff:

Nov 10 2017, 04:00
freetrader added inline comments to D657: BCC -> BCH.
Nov 10 2017, 03:14

Nov 5 2017

freetrader accepted D636: Convert rpc package to use Amount class.
Nov 5 2017, 21:37
freetrader committed rABC2bc42bd0ca41: Comment, cast and assert cleanup in pow.cpp (authored by freetrader).
Comment, cast and assert cleanup in pow.cpp
Nov 5 2017, 10:14
freetrader closed D635: Comment, cast and assert cleanup in pow.cpp by committing rABC2bc42bd0ca41: Comment, cast and assert cleanup in pow.cpp.
Nov 5 2017, 10:14

Nov 4 2017

freetrader added a comment to rABC31b68eb0b59b: Switch to GCC 7 on Travis, disable currently non-functional ARM + Windows builds.

Thanks for testing @jjz . It definitely it takes a long time when the caches are not filled.
Depending on if you're lucky or not (get a slow Travis instance or a faster one) it can even time out at the 50min limit for that first build (did for me).
In which case a platform build may error out and need to be restarted until it passes.

Nov 4 2017, 23:23
freetrader updated the test plan for D635: Comment, cast and assert cleanup in pow.cpp.
Nov 4 2017, 22:53
freetrader retitled D635: Comment, cast and assert cleanup in pow.cpp from Comment and assert cleanup in pow.cpp to Comment, cast and assert cleanup in pow.cpp.
Nov 4 2017, 22:53
freetrader updated the diff for D635: Comment, cast and assert cleanup in pow.cpp.

Explicit conversion to int64_t

Nov 4 2017, 22:30
freetrader updated the diff for D635: Comment, cast and assert cleanup in pow.cpp.

Another grammar fix

Nov 4 2017, 20:26
freetrader updated the diff for D635: Comment, cast and assert cleanup in pow.cpp.

Formatting was still bad, fix

Nov 4 2017, 20:25
freetrader updated the diff for D635: Comment, cast and assert cleanup in pow.cpp.

Fix up the commenting that the lint auto-adjusted

Nov 4 2017, 20:22
Herald added 1 blocking reviewer(s) for D635: Comment, cast and assert cleanup in pow.cpp: Restricted Project.
Nov 4 2017, 20:19
freetrader accepted D634: Convert policy fees.cpp/.h to use Amount class.

Looks good and tests fine.

Nov 4 2017, 13:56

Nov 3 2017

freetrader accepted D633: Update alternates defintion in win gitian descriptor.
Nov 3 2017, 00:27

Oct 31 2017

freetrader committed rABC31b68eb0b59b: Switch to GCC 7 on Travis, disable currently non-functional ARM + Windows builds (authored by freetrader).
Switch to GCC 7 on Travis, disable currently non-functional ARM + Windows builds
Oct 31 2017, 16:42
freetrader closed D626: Switch to GCC 7 on Travis, disable currently non-functional ARM + Windows builds by committing rABC31b68eb0b59b: Switch to GCC 7 on Travis, disable currently non-functional ARM + Windows builds.
Oct 31 2017, 16:42
freetrader added a comment to D626: Switch to GCC 7 on Travis, disable currently non-functional ARM + Windows builds.

For consideration of 0.16.0 release: It is better to have Travis working for a subset of platforms than to have it constantly fail the entire suite

Oct 31 2017, 03:44

Oct 30 2017

freetrader closed T90: Convert format strings using %u for bools to use %d instead as Resolved.

Resolved by D605

Oct 30 2017, 18:13
freetrader claimed T90: Convert format strings using %u for bools to use %d instead.
Oct 30 2017, 18:12
freetrader added a comment to T90: Convert format strings using %u for bools to use %d instead.

Ah, thank you @jasonbcox . The task is not currently assigned to anyone, but I think anyone can grab it and close it.

Oct 30 2017, 18:12

Oct 29 2017

freetrader added a comment to D626: Switch to GCC 7 on Travis, disable currently non-functional ARM + Windows builds.

Test result on Travis with these changes in a private branch:

Oct 29 2017, 02:36
Herald added 1 blocking reviewer(s) for D626: Switch to GCC 7 on Travis, disable currently non-functional ARM + Windows builds: Restricted Project.
Oct 29 2017, 02:35

Oct 26 2017

freetrader committed rABC779785eada81: Fix sporadic policyestimator_tests failure due to unspecified operand… (authored by freetrader).
Fix sporadic policyestimator_tests failure due to unspecified operand…
Oct 26 2017, 18:11
freetrader closed D621: Fix sporadic policyestimator_tests failure due to unspecified operand evaluation order by committing rABC779785eada81: Fix sporadic policyestimator_tests failure due to unspecified operand….
Oct 26 2017, 18:11
freetrader updated the summary of D621: Fix sporadic policyestimator_tests failure due to unspecified operand evaluation order.
Oct 26 2017, 18:09

Oct 24 2017

freetrader added a comment to D621: Fix sporadic policyestimator_tests failure due to unspecified operand evaluation order.

Why is the test flacky ? Why does this fixes it ?

Oct 24 2017, 11:19

Oct 20 2017

Herald added 1 blocking reviewer(s) for D621: Fix sporadic policyestimator_tests failure due to unspecified operand evaluation order: Restricted Project.
Oct 20 2017, 14:30

Oct 18 2017

freetrader accepted D615: Fix mistaken replacement of a.GetModifiedFee in txmempool.h.
Oct 18 2017, 14:51

Oct 5 2017

freetrader committed rABC097f88c4566d: Build C code in seeder with PIE_FLAGS (authored by freetrader).
Build C code in seeder with PIE_FLAGS
Oct 5 2017, 23:31
freetrader closed D582: Build C code in seeder with PIE_FLAGS by committing rABC097f88c4566d: Build C code in seeder with PIE_FLAGS.
Oct 5 2017, 23:31
freetrader updated the diff for D582: Build C code in seeder with PIE_FLAGS.

Fix dropped parenthesis

Oct 5 2017, 15:30
freetrader updated the diff for D582: Build C code in seeder with PIE_FLAGS.

Move PIE_FLAGS to more appropriate location

Oct 5 2017, 14:29

Oct 4 2017

Herald added 1 blocking reviewer(s) for D582: Build C code in seeder with PIE_FLAGS: Restricted Project.
Oct 4 2017, 20:50
freetrader committed rABCfa62fec24444: Remove duplicated code which can be obtained by linking crypto lib (authored by freetrader).
Remove duplicated code which can be obtained by linking crypto lib
Oct 4 2017, 16:42
freetrader closed D581: Remove duplicated code which can be obtained by linking crypto lib by committing rABCfa62fec24444: Remove duplicated code which can be obtained by linking crypto lib.
Oct 4 2017, 16:42
Herald added 1 blocking reviewer(s) for D581: Remove duplicated code which can be obtained by linking crypto lib: Restricted Project.
Oct 4 2017, 15:37

Sep 21 2017

freetrader accepted D551: Use a single node in high_priority_transaction test to prevent sync problems.

I tested on a machine with previous failure rate of > 10% , for more than 100 iterations without problem.

Sep 21 2017, 21:56

Sep 17 2017

freetrader committed rABC688e2640b992: Heal broken build (D529) by adding missing GetSatoshis() conversion calls (authored by freetrader).
Heal broken build (D529) by adding missing GetSatoshis() conversion calls
Sep 17 2017, 06:13
freetrader closed D545: Heal broken build (D529) by adding missing GetSatoshis() conversion calls by committing rABC688e2640b992: Heal broken build (D529) by adding missing GetSatoshis() conversion calls.
Sep 17 2017, 06:13

Sep 16 2017

Herald added 1 blocking reviewer(s) for D545: Heal broken build (D529) by adding missing GetSatoshis() conversion calls: Restricted Project.
Sep 16 2017, 21:49
freetrader committed rABC114175fd9c4d: Fix PYTHONPATH export association in Makefile.am (authored by freetrader).
Fix PYTHONPATH export association in Makefile.am
Sep 16 2017, 07:02
freetrader closed D543: Fix PYTHONPATH export association in Makefile.am by committing rABC114175fd9c4d: Fix PYTHONPATH export association in Makefile.am.
Sep 16 2017, 07:02

Sep 15 2017

freetrader updated the summary of D543: Fix PYTHONPATH export association in Makefile.am.
Sep 15 2017, 20:20
freetrader added a comment to D543: Fix PYTHONPATH export association in Makefile.am.

Test results:

Sep 15 2017, 20:18
Herald added 1 blocking reviewer(s) for D543: Fix PYTHONPATH export association in Makefile.am: Restricted Project.
Sep 15 2017, 20:04

Sep 14 2017

freetrader committed rABC2ead605dc1e4: Filter out pyenv from Travis path to fix python3.6 Travis errors (authored by Cory Fields <cory-nospam-@coryfields.com>).
Filter out pyenv from Travis path to fix python3.6 Travis errors
Sep 14 2017, 17:23
freetrader closed D542: Filter out pyenv from Travis path to fix python3.6 Travis errors by committing rABC2ead605dc1e4: Filter out pyenv from Travis path to fix python3.6 Travis errors (authored by Cory Fields <cory-nospam-@coryfields.com>).
Sep 14 2017, 17:23
freetrader added a comment to D542: Filter out pyenv from Travis path to fix python3.6 Travis errors.

This has been verified in a Travis-checked branch:
https://travis-ci.org/ftrader-bitcoinabc/bitcoin-abc/builds/275536583

Sep 14 2017, 17:02
Herald added 1 blocking reviewer(s) for D542: Filter out pyenv from Travis path to fix python3.6 Travis errors: Restricted Project.
Sep 14 2017, 17:00

Sep 1 2017

freetrader accepted D518: Reduce the number of nodes from 4 to 2 in `getblocktemplate_longpoll.py`.
Sep 1 2017, 00:35
freetrader accepted D485: Set default space reserved for hiprio txns to 5% of max generated block size.
Sep 1 2017, 00:32

Aug 31 2017

freetrader requested changes to D485: Set default space reserved for hiprio txns to 5% of max generated block size.
Aug 31 2017, 18:39
freetrader added a comment to D514: Fix ZMQ test occasional hang and modernize it.

Travis is also happy again

Aug 31 2017, 17:39
freetrader added a comment to D485: Set default space reserved for hiprio txns to 5% of max generated block size.

Generally: I think it would be nice to have an RPC interface to allow miners to get/set the current blockprioritypercentage . This might be more involved though, so it's best dealt with in a separate diff at some stage I think (it's also not very urgent, a configuration parameter is a good start).

Aug 31 2017, 17:31
freetrader committed rABC12c8a2426d36: Fix ZMQ test occasional hang and modernize it (authored by freetrader).
Fix ZMQ test occasional hang and modernize it
Aug 31 2017, 16:11
freetrader closed D514: Fix ZMQ test occasional hang and modernize it by committing rABC12c8a2426d36: Fix ZMQ test occasional hang and modernize it.
Aug 31 2017, 16:11
freetrader updated the summary of D514: Fix ZMQ test occasional hang and modernize it.
Aug 31 2017, 12:56
Herald added 1 blocking reviewer(s) for D514: Fix ZMQ test occasional hang and modernize it: Restricted Project.
Aug 31 2017, 12:52

Aug 30 2017

freetrader accepted D510: OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change related OSX-specific handlers and Info.plist stuff to match..

Looks good, didn't find any other instances of Bitcoin-Qt that we want to change at this point
(there are some, but it's been noted that they affect the app id as far as Qt is concerned, and if we change them it will make the preferences files and Windows registry keys have a different unique id,
so users would lose their GUI preferences - these will be dealt with by migration code in further diff.

Aug 30 2017, 21:07
freetrader added inline comments to D485: Set default space reserved for hiprio txns to 5% of max generated block size.
Aug 30 2017, 20:14
freetrader accepted D511: Remove unused hasModifier flag.
Aug 30 2017, 20:09
freetrader added a comment to D510: OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change related OSX-specific handlers and Info.plist stuff to match..
In D510#8986, @CCulianu wrote:

Ok, I can do that at a later time (like later tonight or tomorrow morning) -- or freetrader -- if you're already set up mind doing it since.. well.. you're already set up?

Aug 30 2017, 19:04
freetrader committed rABC077efc5d37ba: Add note to Github repo for easier cloning of development source tree (authored by freetrader).
Add note to Github repo for easier cloning of development source tree
Aug 30 2017, 15:43
freetrader closed D509: Add note to Github repo for easier cloning of development source tree by committing rABC077efc5d37ba: Add note to Github repo for easier cloning of development source tree.
Aug 30 2017, 15:43
freetrader committed rABC1b983a1986dc: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers (authored by freetrader).
Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers
Aug 30 2017, 14:18
freetrader closed D508: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers by committing rABC1b983a1986dc: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers.
Aug 30 2017, 14:18
freetrader updated the diff for D508: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers.

Fix CFBundleURLSchemes

Aug 30 2017, 14:04
freetrader added inline comments to D508: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers.
Aug 30 2017, 13:56
freetrader retitled D508: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers from [WIP] Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers to Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers.
Aug 30 2017, 13:35
freetrader updated the diff for D509: Add note to Github repo for easier cloning of development source tree.

Fix broken URL

Aug 30 2017, 13:33
Herald added 1 blocking reviewer(s) for D509: Add note to Github repo for easier cloning of development source tree: Restricted Project.
Aug 30 2017, 13:31
freetrader added a comment to D508: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers.

Travis test passed:
https://travis-ci.org/ftrader-bitcoinabc/bitcoin-abc/builds/269961272

Aug 30 2017, 12:19
freetrader added a comment to D508: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers.

Gitian builds and the extended tests worked alright.
Travis testing seems blocked by a hanging test on HEAD at the moment - I'll push this on a branch off the last passing commit to test.

Aug 30 2017, 11:11
Herald added 1 blocking reviewer(s) for D508: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers: Restricted Project.
Aug 30 2017, 10:00

Aug 28 2017

freetrader committed rABC7a0048edc78c: Fix proxy_test logging crash when no IPv6 available (authored by freetrader).
Fix proxy_test logging crash when no IPv6 available
Aug 28 2017, 22:18
freetrader closed D504: Fix proxy_test logging crash when no IPv6 available by committing rABC7a0048edc78c: Fix proxy_test logging crash when no IPv6 available.
Aug 28 2017, 22:18
freetrader added inline comments to D501: [net] Allow disconnectnode RPC to be called with node id.
Aug 28 2017, 21:27
freetrader requested review of D504: Fix proxy_test logging crash when no IPv6 available.
Aug 28 2017, 19:55
freetrader updated the test plan for D504: Fix proxy_test logging crash when no IPv6 available.
Aug 28 2017, 19:48
freetrader added a comment to D504: Fix proxy_test logging crash when no IPv6 available.

@deadalnix : after the T97 crash showed up on Travis, I compared the recent (0.15) Core proxy_test.py with ours, and indeed they applied the same fix by moving that code into setup_nodes().

Aug 28 2017, 19:47
Herald added 1 blocking reviewer(s) for D504: Fix proxy_test logging crash when no IPv6 available: Restricted Project.
Aug 28 2017, 18:07
freetrader accepted D497: Workaround to Travis-CI Wine/Mingw build hanging occasionally.
Aug 28 2017, 16:42
freetrader accepted D499: [qa] Add logging to test_framework.py.

All ok with me.

Aug 28 2017, 13:11