Page MenuHomePhabricator

Use a single node in high_priority_transaction test to prevent sync problems
ClosedPublic

Authored by tomtomtom7 on Sep 21 2017, 08:26.

Details

Summary

The test failed irregularly. See T103.

This was probably caused by transactions being synced between node 0 and node 1 after/during the block generation on node 1.

Changed to use a single node.

Test Plan

I can't confirm it works, as it was failing very rarely on my setup.

Please test on the travis instant with >10% failure rate.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Sep 21 2017, 08:26

testing now report back later.

Run high_priority_transaction.py 240 times in a loop and didn't experience any failure. Previously I got around 7-10% failure ratio.

Wonder if we could achieve the same waiting for the txns to propagate before mining the block on node 1.

This revision is now accepted and ready to land.Sep 21 2017, 18:38

I tested on a machine with previous failure rate of > 10% , for more than 100 iterations without problem.

This revision was automatically updated to reflect the committed changes.