Page MenuHomePhabricator

sickpig (sickpig)
User

Projects

User does not belong to any projects.

User Details

User Since
May 31 2017, 08:30 (80 w, 3 d)

Recent Activity

Sun, Nov 18

sickpig added inline comments to D2083: Add an RPC to finalize a block.
Sun, Nov 18, 15:11

Sep 27 2018

sickpig committed rSTAGINGaa4cd96c94a2: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM (authored by sickpig).
Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM
Sep 27 2018, 18:50

Sep 12 2018

sickpig added inline comments to D1772: Prevent -Wshadow warnings with gcc versions 4.8.5, 5.3.1 and 6.2.1..
Sep 12 2018, 13:39

May 25 2018

sickpig abandoned D1449: Add src/test/buildenv.py to .gitignore.

​src/test/buildenv.py has been generated by an old in-tree build from late 2017, it is not used anymore. sorry for the noise.

May 25 2018, 07:22

May 24 2018

sickpig added a comment to D1449: Add src/test/buildenv.py to .gitignore.

What is this file, why do we want to ignore it ?

May 24 2018, 14:25
sickpig committed rABCaa4cd96c94a2: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM (authored by sickpig).
Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM
May 24 2018, 14:24
sickpig closed D1446: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM.
May 24 2018, 14:24
sickpig updated the diff for D1446: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM.

internal branch reorg. no code changes

May 24 2018, 13:56
sickpig updated the diff for D1449: Add src/test/buildenv.py to .gitignore.

remove a spurios commit

May 24 2018, 13:54
sickpig added a comment to D1449: Add src/test/buildenv.py to .gitignore.

last change wasn't supposed to update this diff.. fixing

May 24 2018, 13:47
sickpig updated the diff for D1446: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM.

Format comment

May 24 2018, 13:45
sickpig updated the diff for D1449: Add src/test/buildenv.py to .gitignore.

Format comment

May 24 2018, 13:43
sickpig accepted D1444: Remove remains of extension blocks.
May 24 2018, 12:16
sickpig accepted D1448: Fix copyright and name of the sighashtype test..

diff seems sensible even if automatic build fails (https://reviews.bitcoinabc.org/harbormaster/build/3370/), it seems more an infrastructure problem rather than a code problem

May 24 2018, 12:14
Herald added a reviewer for D1449: Add src/test/buildenv.py to .gitignore: Restricted Project.
May 24 2018, 12:05
sickpig updated the diff for D1446: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM.

Squash local commits

May 24 2018, 11:59
sickpig updated the diff for D1446: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM.

Remove src/test/buildenv.py

May 24 2018, 11:56
sickpig added a comment to D1446: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM.

Dunno why but for some reason I seem to have added src/test/buildenv.py by error, wonder if we could add it to .gitignore

May 24 2018, 09:49
Herald added a reviewer for D1446: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM: Restricted Project.
May 24 2018, 09:47

Apr 9 2018

sickpig updated subscribers of D1258: [secp256k1] Make sure we get the requested number of bytes from /dev/urandom.

nothing wrong with the diff, but wasn't secp256k1 handled as a subtree? is this changed since @tomtomtom7's utxo commitments patches?

Apr 9 2018, 12:46

Mar 1 2018

sickpig committed rSTAGING42798d906d16: Remove IsPayToWitnessScriptHash (authored by sickpig).
Remove IsPayToWitnessScriptHash
Mar 1 2018, 23:45

Jan 24 2018

sickpig committed rABC42798d906d16: Remove IsPayToWitnessScriptHash (authored by sickpig).
Remove IsPayToWitnessScriptHash
Jan 24 2018, 15:59
sickpig closed D1030: Remove IsPayToWitnessScriptHash.
Jan 24 2018, 15:59
Herald added a reviewer for D1030: Remove IsPayToWitnessScriptHash: Restricted Project.
Jan 24 2018, 13:46

Jan 17 2018

sickpig added inline comments to D970: Skip rpcbind_test if OS/network requirements are not met..
Jan 17 2018, 15:25
sickpig added inline comments to D970: Skip rpcbind_test if OS/network requirements are not met..
Jan 17 2018, 15:08

Jan 15 2018

sickpig added a comment to D962: Prepare a flag for charging for excessive utxo creation.

patch is still WIP right? cause I don't see any criteria on how to apply excessUTXOCharge

Jan 15 2018, 21:35
sickpig accepted D958: Fix blockchain.py.
Jan 15 2018, 12:06

Jan 9 2018

sickpig abandoned D859: Add `config.ini` to test/functional/.gitignore.

superseded by D866

Jan 9 2018, 09:55
sickpig added a comment to D859: Add `config.ini` to test/functional/.gitignore.

Can you explain how you end up with that file generated ?

Jan 9 2018, 09:55

Jan 2 2018

sickpig added a comment to D856: Permit to set `minrelaytxfee` to 0.

On second thought I think I will setup a new unit test to see if minrelayfee could be set to 0 and leave the more complete functional test on D554.

Jan 2 2018, 15:29
sickpig added a comment to D856: Permit to set `minrelaytxfee` to 0.

Test you referring to is part of D554 as this change was.

Jan 2 2018, 15:19
sickpig updated the diff for D554: Change default for key fee transactions policies.

rebased on top of master and D856

Jan 2 2018, 13:16
sickpig added a parent revision for D554: Change default for key fee transactions policies: D856: Permit to set `minrelaytxfee` to 0.
Jan 2 2018, 13:16
sickpig added a child revision for D856: Permit to set `minrelaytxfee` to 0: D554: Change default for key fee transactions policies.
Jan 2 2018, 13:16

Jan 1 2018

sickpig added a reviewer for D856: Permit to set `minrelaytxfee` to 0: schancel.
Jan 1 2018, 16:28
Herald added a reviewer for D859: Add `config.ini` to test/functional/.gitignore: Restricted Project.
Jan 1 2018, 14:13
sickpig updated the diff for D856: Permit to set `minrelaytxfee` to 0.
  1. just wanted to further specify that minrelaytxfee will be overruled once the mempool will get full and mempol accpetance fee will be modified via incrementalrelay
Jan 1 2018, 14:11
sickpig committed rABC6726ab1decb2: Autopep8 test/functional/test_runner.py (authored by sickpig).
Autopep8 test/functional/test_runner.py
Jan 1 2018, 13:49
sickpig closed D857: Autopep8 test/functional/test_runner.py.
Jan 1 2018, 13:49

Dec 31 2017

sickpig added a reviewer for D857: Autopep8 test/functional/test_runner.py: schancel.
Dec 31 2017, 15:54
Herald added a reviewer for D857: Autopep8 test/functional/test_runner.py: Restricted Project.
Dec 31 2017, 15:53
sickpig added inline comments to D554: Change default for key fee transactions policies.
Dec 31 2017, 15:48
Herald added a reviewer for D856: Permit to set `minrelaytxfee` to 0: Restricted Project.
Dec 31 2017, 15:25

Dec 29 2017

sickpig added a comment to D554: Change default for key fee transactions policies.

I partly agree, but we have to take into consideration that theoretically it is not possible to relay more than 20KB of free transactions per minute. Hence 200KB worth of free transactions per block.

Dec 29 2017, 17:45

Dec 27 2017

sickpig updated the summary of D554: Change default for key fee transactions policies.
Dec 27 2017, 22:30
sickpig updated the diff for D554: Change default for key fee transactions policies.
  • modify sendrawtransaction (in src/rpc/rawtransaction.cpp) so that locally generated transaction is rate limited accordinf to limiterfreerelay
Dec 27 2017, 22:27
sickpig updated the diff for D554: Change default for key fee transactions policies.

Change default for key fee transactions policies

Dec 27 2017, 22:18

Dec 15 2017

sickpig updated the diff for D554: Change default for key fee transactions policies.
  • Add unit test to verify that 0 fee non high priority transactions are selected for inclusion in a block.
  • let minrelaytxfee to be set to 0.
Dec 15 2017, 14:26

Dec 11 2017

sickpig updated the diff for D554: Change default for key fee transactions policies.

These set of changes fixed a runtime error occuring during the execution of miner_tests.
It was due to the use of ForceSetArg in TestPackageSelection to change the default value of blockMinFeeRate.

Dec 11 2017, 16:25

Dec 7 2017

sickpig updated the diff for D554: Change default for key fee transactions policies.

Add comment to explain what DEFAULT_LIMITFREERELAY is

Dec 7 2017, 16:38
sickpig updated the diff for D554: Change default for key fee transactions policies.

Rebased

Dec 7 2017, 09:52
sickpig added inline comments to D554: Change default for key fee transactions policies.
Dec 7 2017, 09:47

Oct 30 2017

sickpig accepted D629: Update version for 0.16.0 release.
Oct 30 2017, 21:05
sickpig requested changes to D629: Update version for 0.16.0 release.
Oct 30 2017, 20:47

Sep 30 2017

sickpig added a comment to D571: Implement the proposed difficulty adjustement algorithm proposed in the ML.

Guess that a link to the email where the algo is described should be put somewhere in the code comment or in the commit message

Sep 30 2017, 12:32

Sep 28 2017

sickpig accepted D570: Remove BU testnet seeder.
Sep 28 2017, 19:46
sickpig accepted D560: Numerous improvement to the seeder's code.
Sep 28 2017, 19:46
sickpig accepted D567: Update main net seed list to containe only nodes that support the new magic.
Sep 28 2017, 09:26
sickpig accepted D565: Remove all warning in the seeder.
Sep 28 2017, 09:26
sickpig accepted D562: Use sync locking primitives in the seeder.
Sep 28 2017, 09:24
sickpig accepted D561: Use cstdint in seeder.
Sep 28 2017, 09:16
sickpig added inline comments to D561: Use cstdint in seeder.
Sep 28 2017, 09:16
sickpig added inline comments to D560: Numerous improvement to the seeder's code.
Sep 28 2017, 09:14
sickpig accepted D559: Make bitcoin-seeder a first class citizen of ABC.
Sep 28 2017, 09:05
sickpig accepted D568: Update bitcoin seeder UA string.
Sep 28 2017, 09:04

Sep 27 2017

sickpig accepted D559: Make bitcoin-seeder a first class citizen of ABC.

wonder if you could have used git subtree rather than including the code directly in the ABC tree

Sep 27 2017, 15:55
sickpig requested changes to D565: Remove all warning in the seeder.
Sep 27 2017, 15:53
sickpig accepted D567: Update main net seed list to containe only nodes that support the new magic.
Sep 27 2017, 15:53
sickpig requested changes to D560: Numerous improvement to the seeder's code.
Sep 27 2017, 15:52
sickpig added inline comments to D560: Numerous improvement to the seeder's code.
Sep 27 2017, 15:52
sickpig added a comment to D566: Use cinttypes.

did't mean to accept to for the all abc project, forgot to untick the check button.

Sep 27 2017, 13:45
sickpig accepted D566: Use cinttypes.
Sep 27 2017, 13:44
sickpig requested changes to D561: Use cstdint in seeder.
Sep 27 2017, 13:44
sickpig accepted D562: Use sync locking primitives in the seeder.
Sep 27 2017, 13:27
sickpig added a comment to D564: Use bitcoin's serialization and uint256 implementation in the seeder..

nice addition

Sep 27 2017, 13:25
sickpig added inline comments to D565: Remove all warning in the seeder.
Sep 27 2017, 13:23
sickpig requested changes to D567: Update main net seed list to containe only nodes that support the new magic.
Sep 27 2017, 13:20
sickpig added inline comments to D567: Update main net seed list to containe only nodes that support the new magic.
Sep 27 2017, 13:20
sickpig accepted D568: Update bitcoin seeder UA string.
Sep 27 2017, 13:19

Sep 22 2017

sickpig updated the diff for D554: Change default for key fee transactions policies.

Add WIP to title a list of TODO taks

Sep 22 2017, 15:50
Herald added a reviewer for D554: Change default for key fee transactions policies: Restricted Project.
Sep 22 2017, 15:42
sickpig accepted D550: Ensure backupwallet fails if the target is the same as the source.
Sep 22 2017, 14:57
sickpig added inline comments to D550: Ensure backupwallet fails if the target is the same as the source.
Sep 22 2017, 14:45

Sep 21 2017

sickpig added a comment to T101: add RPC command for percentage of blocksize.

100% agreed on having an a Task where to discuss about how to reload bitcoin.conf, be it via a RPC command reload_config or via a SIGHUP sent to bitcoind.

Sep 21 2017, 19:00
sickpig added a comment to T101: add RPC command for percentage of blocksize.

I guess that we need to weight if the added complexity justify the addition of the RPC command.

Sep 21 2017, 16:15
sickpig accepted D551: Use a single node in high_priority_transaction test to prevent sync problems.

Run high_priority_transaction.py 240 times in a loop and didn't experience any failure. Previously I got around 7-10% failure ratio.

Sep 21 2017, 15:14
sickpig added a comment to D551: Use a single node in high_priority_transaction test to prevent sync problems.

testing now report back later.

Sep 21 2017, 14:35
sickpig added inline comments to D550: Ensure backupwallet fails if the target is the same as the source.
Sep 21 2017, 07:45

Sep 11 2017

sickpig accepted D536: boost::ref => std::ref.
Sep 11 2017, 08:56
sickpig accepted D537: boost::shared_ptr => std::shared_ptr.
Sep 11 2017, 08:53

Sep 6 2017

sickpig accepted D520: Extract the flag selection logic out of CheckBlock.
Sep 6 2017, 20:10
sickpig accepted D524: Various nits in the signature cache machinery.
Sep 6 2017, 20:08
sickpig added inline comments to D530: Cache script execution on a per transaction basis.
Sep 6 2017, 20:04
sickpig accepted D507: Return on disk and DB independent size for the utxo set.
Sep 6 2017, 14:48

Sep 5 2017

sickpig committed rABC9a51fb18f55f: Set default space reserved for hiprio txns to 5% of max generated block size (authored by sickpig).
Set default space reserved for hiprio txns to 5% of max generated block size
Sep 5 2017, 21:06
sickpig closed D485: Set default space reserved for hiprio txns to 5% of max generated block size by committing rABC9a51fb18f55f: Set default space reserved for hiprio txns to 5% of max generated block size.
Sep 5 2017, 21:06
sickpig updated the diff for D485: Set default space reserved for hiprio txns to 5% of max generated block size.

Remove commented log statement in high_priority_transaction.py
Avoid passing config to addPriotityTxs as a parameter use the member in the object

Sep 5 2017, 21:03
sickpig added inline comments to D485: Set default space reserved for hiprio txns to 5% of max generated block size.
Sep 5 2017, 19:42
sickpig added inline comments to D485: Set default space reserved for hiprio txns to 5% of max generated block size.
Sep 5 2017, 19:30