Prevent -Wshadow warnings with gcc versions 4.8.5, 5.3.1 and 6.2.1.
ClosedPublic
Actions

Authored by deadalnix on Sep 12 2018, 13:06.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING33199e2c93c7: Prevent -Wshadow warnings with gcc versions 4.8.5, 5.3.1 and 6.2.1.
rABC33199e2c93c7: Prevent -Wshadow warnings with gcc versions 4.8.5, 5.3.1 and 6.2.1.

Summary

Backport of core PR9911

Test Plan

make check

Compile with shaddow flag

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 12 2018, 13:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2018, 13:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

sickpig added a subscriber: sickpig.Sep 12 2018, 13:38

sickpig added inline comments.

src/test/script_tests.cpp
39 ↗	(On Diff #4892)	why changing var type?

Harbormaster failed remote builds in B3279: Diff 4892!Sep 12 2018, 13:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

restore flags type.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3282: Diff 4895.Sep 12 2018, 14:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added inline comments.Sep 12 2018, 15:20

src/test/script_tests.cpp
39 ↗	(On Diff #4892)	Mistake.

schancel accepted this revision.Sep 15 2018, 15:11

This revision is now accepted and ready to land.Sep 15 2018, 15:11

Closed by commit rABC33199e2c93c7: Prevent -Wshadow warnings with gcc versions 4.8.5, 5.3.1 and 6.2.1. (authored by Pavel Janík <Pavel@Janik.cz>, committed by deadalnix). · Explain WhySep 15 2018, 17:00

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

script_tests.cpp

28 lines

Diff 4918

View Options

Prevent -Wshadow warnings with gcc versions 4.8.5, 5.3.1 and 6.2.1.ClosedPublicActions