urandom
ClosedPublic
Actions

Authored by deadalnix on Apr 8 2018, 15:53.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING2fd74f214029: [secp256k1] Make sure we get the requested number of bytes from /dev/urandom
rABC2fd74f214029: [secp256k1] Make sure we get the requested number of bytes from /dev/urandom

Summary

Backport PR499 from practicalswift

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 8 2018, 15:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2018, 15:53

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2261: Diff 3426.Apr 8 2018, 18:34

schancel accepted this revision.Apr 9 2018, 04:25

This revision is now accepted and ready to land.Apr 9 2018, 04:25

nothing wrong with the diff, but wasn't secp256k1 handled as a subtree? is this changed since @tomtomtom7's utxo commitments patches?

In D1258#24894, @sickpig wrote:

nothing wrong with the diff, but wasn't secp256k1 handled as a subtree? is this changed since @tomtomtom7's utxo commitments patches?

The D1072 UTXO patches certainly deviate from upstream as it is not accepted there. But I would think you can still pull updates using a subtree if needed? The deviation is mostly new files and conflicts are unlikely.

Closed by commit rABC2fd74f214029: [secp256k1] Make sure we get the requested number of bytes from /dev/urandom (authored by deadalnix). · Explain WhyApr 9 2018, 15:23

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

tests.c

2 lines

Diff 3453

View Options

[secp256k1] Make sure we get the requested number of bytes from /dev/urandomClosedPublicActions