Page MenuHomePhabricator

[secp256k1] Make sure we get the requested number of bytes from /dev/urandom
ClosedPublic

Authored by deadalnix on Apr 8 2018, 15:53.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Apr 8 2018, 15:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2018, 15:53
schancel accepted this revision.Apr 9 2018, 04:25
This revision is now accepted and ready to land.Apr 9 2018, 04:25

nothing wrong with the diff, but wasn't secp256k1 handled as a subtree? is this changed since @tomtomtom7's utxo commitments patches?

nothing wrong with the diff, but wasn't secp256k1 handled as a subtree? is this changed since @tomtomtom7's utxo commitments patches?

The D1072 UTXO patches certainly deviate from upstream as it is not accepted there. But I would think you can still pull updates using a subtree if needed? The deviation is mostly new files and conflicts are unlikely.

This revision was automatically updated to reflect the committed changes.