Page MenuHomePhabricator

tomtomtom7 (Tomas van der Wansem)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 12 2017, 11:33 (114 w, 11 h)

Recent Activity

Sep 27 2018

tomtomtom7 committed rSTAGINGf4f00f4ed342: Add ECMH multiset module to libsecp256k1 (authored by tomtomtom7).
Add ECMH multiset module to libsecp256k1
Sep 27 2018, 18:42

Jul 12 2018

tomtomtom7 added inline comments to D1513: Add test/data directory to enable make check.
Jul 12 2018, 12:38

Jun 27 2018

tomtomtom7 added a comment to D1513: Add test/data directory to enable make check.

On fresh checkout, "make check" after cmake fails because the directory "test/data" doesn't exists (at least on my config; I am a bit new to cmake):

Jun 27 2018, 18:16

Jun 24 2018

Herald added a reviewer for D1514: Update EMCH testvectors to match UTXO serialization: Restricted Project.
Jun 24 2018, 14:51
Herald added a reviewer for D1513: Add test/data directory to enable make check: Restricted Project.
Jun 24 2018, 14:42

Jun 21 2018

tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.
  • Use simplified serialization (4b height + 1b iscoinbase)
  • Use boost::noncopyable
Jun 21 2018, 13:38

Jun 18 2018

tomtomtom7 added inline comments to D1074: Add Utxo Commitment wrapper around libsecp256k1.
Jun 18 2018, 12:59

Jun 15 2018

tomtomtom7 added inline comments to D1117: Integrate UtxoCommitment in CCoinView.
Jun 15 2018, 08:35

Jun 14 2018

tomtomtom7 added inline comments to D1110: Add UTXO commitment contruction from UTXO cursor.
Jun 14 2018, 12:51

Jun 11 2018

tomtomtom7 accepted D1495: Add unit tests for combining UTXO commitments..

Lookg good

Jun 11 2018, 19:07

Jun 4 2018

tomtomtom7 added a comment to T292: Include UTXO commitment in the coinbase on block building.

Ref D1474

Jun 4 2018, 14:30

Jun 1 2018

tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Use CompactSize instead of VARINT

Jun 1 2018, 08:10

May 31 2018

Herald added a reviewer for D1474: Include unverified UTXO commitment in Coinbase on generate: Restricted Project.
May 31 2018, 14:41
tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Rebasing to master and minor fixes from review at Bitcoin XT

May 31 2018, 12:03

Apr 26 2018

tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Revert to signed chars for serialization

Apr 26 2018, 11:05

Apr 16 2018

tomtomtom7 added inline comments to D1074: Add Utxo Commitment wrapper around libsecp256k1.
Apr 16 2018, 10:19
tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Thread safe context initialization and various small fixes

Apr 16 2018, 10:11

Apr 9 2018

tomtomtom7 added a comment to D1258: [secp256k1] Make sure we get the requested number of bytes from /dev/urandom.

nothing wrong with the diff, but wasn't secp256k1 handled as a subtree? is this changed since @tomtomtom7's utxo commitments patches?

Apr 9 2018, 13:06
tomtomtom7 committed rABCf4f00f4ed342: Add ECMH multiset module to libsecp256k1 (authored by tomtomtom7).
Add ECMH multiset module to libsecp256k1
Apr 9 2018, 12:17
tomtomtom7 closed D1072: Add ECMH multiset module to libsecp256k1.
Apr 9 2018, 12:17

Mar 15 2018

tomtomtom7 added a subtask for T255: UTXO commitments: T296: Include verified UTXO commitments.
Mar 15 2018, 13:15
tomtomtom7 added a parent task for T296: Include verified UTXO commitments: T255: UTXO commitments.
Mar 15 2018, 13:15
tomtomtom7 renamed T296: Include verified UTXO commitments from Include verifies UTXO commitments to Include verified UTXO commitments.
Mar 15 2018, 13:14
tomtomtom7 triaged T296: Include verified UTXO commitments as Normal priority.
Mar 15 2018, 13:14
tomtomtom7 added a subtask for T291: Add UTXO peer2peer messages: T295: Add utxo and getutxo messages.
Mar 15 2018, 13:13
tomtomtom7 added a parent task for T295: Add utxo and getutxo messages: T291: Add UTXO peer2peer messages.
Mar 15 2018, 13:13
tomtomtom7 triaged T295: Add utxo and getutxo messages as Normal priority.
Mar 15 2018, 13:13
tomtomtom7 added a parent task for T294: Enable ranged access to the CoinsDB: T291: Add UTXO peer2peer messages.
Mar 15 2018, 13:11
tomtomtom7 added a subtask for T291: Add UTXO peer2peer messages: T294: Enable ranged access to the CoinsDB.
Mar 15 2018, 13:11
tomtomtom7 triaged T294: Enable ranged access to the CoinsDB as Normal priority.
Mar 15 2018, 13:11
tomtomtom7 added a parent task for T293: Include UTXO commitment in getblocktemplate: T289: Maintain and include unverified UTXO commitments.
Mar 15 2018, 13:08
tomtomtom7 added a subtask for T289: Maintain and include unverified UTXO commitments: T293: Include UTXO commitment in getblocktemplate.
Mar 15 2018, 13:08
tomtomtom7 triaged T293: Include UTXO commitment in getblocktemplate as Normal priority.
Mar 15 2018, 13:07
tomtomtom7 removed a subtask for T218: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously: T292: Include UTXO commitment in the coinbase on block building.
Mar 15 2018, 13:06
tomtomtom7 removed a parent task for T292: Include UTXO commitment in the coinbase on block building: T218: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously.
Mar 15 2018, 13:06
tomtomtom7 added a subtask for T218: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously: T292: Include UTXO commitment in the coinbase on block building.
Mar 15 2018, 13:06
tomtomtom7 added parent tasks for T292: Include UTXO commitment in the coinbase on block building: T218: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously, T289: Maintain and include unverified UTXO commitments.
Mar 15 2018, 13:06
tomtomtom7 added a subtask for T289: Maintain and include unverified UTXO commitments: T292: Include UTXO commitment in the coinbase on block building.
Mar 15 2018, 13:06
tomtomtom7 triaged T292: Include UTXO commitment in the coinbase on block building as Normal priority.
Mar 15 2018, 13:05
tomtomtom7 added a parent task for T291: Add UTXO peer2peer messages: T255: UTXO commitments.
Mar 15 2018, 13:03
tomtomtom7 added a subtask for T255: UTXO commitments: T291: Add UTXO peer2peer messages.
Mar 15 2018, 13:03
tomtomtom7 triaged T291: Add UTXO peer2peer messages as Normal priority.
Mar 15 2018, 13:02
tomtomtom7 added a parent task for T290: Maintain UTXO commitment and expose RPC: T289: Maintain and include unverified UTXO commitments.
Mar 15 2018, 13:01
tomtomtom7 added a subtask for T289: Maintain and include unverified UTXO commitments: T290: Maintain UTXO commitment and expose RPC.
Mar 15 2018, 13:01
tomtomtom7 triaged T290: Maintain UTXO commitment and expose RPC as Normal priority.
Mar 15 2018, 13:00
tomtomtom7 added a subtask for T255: UTXO commitments: T289: Maintain and include unverified UTXO commitments.
Mar 15 2018, 12:57
tomtomtom7 added a parent task for T289: Maintain and include unverified UTXO commitments: T255: UTXO commitments.
Mar 15 2018, 12:57
tomtomtom7 triaged T289: Maintain and include unverified UTXO commitments as Normal priority.
Mar 15 2018, 12:57

Mar 8 2018

tomtomtom7 updated the diff for D1117: Integrate UtxoCommitment in CCoinView.

Minor fix in comments

Mar 8 2018, 14:37
tomtomtom7 updated the test plan for D1117: Integrate UtxoCommitment in CCoinView.
Mar 8 2018, 14:34
tomtomtom7 updated the diff for D1117: Integrate UtxoCommitment in CCoinView.

Add another RPC test, fix up some comments.

Mar 8 2018, 14:29

Mar 7 2018

tomtomtom7 updated the diff for D1117: Integrate UtxoCommitment in CCoinView.

Include third testvector in RPC test

Mar 7 2018, 15:39
tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.

Changed testvector 3 input and output

Mar 7 2018, 15:35

Mar 6 2018

tomtomtom7 abandoned D1110: Add UTXO commitment contruction from UTXO cursor.

This is no integrated in D1074

Mar 6 2018, 14:09
tomtomtom7 updated the diff for D1117: Integrate UtxoCommitment in CCoinView.

Add first RPC test for UTXO commitment

Mar 6 2018, 14:08
tomtomtom7 updated the summary of D1117: Integrate UtxoCommitment in CCoinView.
Mar 6 2018, 11:55
Herald added 1 blocking reviewer(s) for D1074: Add Utxo Commitment wrapper around libsecp256k1: Restricted Project.
Mar 6 2018, 11:55
tomtomtom7 updated the diff for D1117: Integrate UtxoCommitment in CCoinView.

Fix several logic errors and add commitment_calculated to the gettxoutsetinfo

Mar 6 2018, 11:55

Mar 3 2018

tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.

Add testvector test for empty set

Mar 3 2018, 22:51
tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Empty update to reflect changes in D1072

Mar 3 2018, 15:57
tomtomtom7 added inline comments to D1072: Add ECMH multiset module to libsecp256k1.
Mar 3 2018, 14:54
tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.

Return 0 instead of SHA(0) for the empty multiset

Mar 3 2018, 14:53

Mar 2 2018

tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

No changes; just moved some stuff to previous diff for clarity

Mar 2 2018, 14:07
tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Change combining constructor to add method

Mar 2 2018, 14:05
tomtomtom7 accepted D1148: Make dates explicit and fix erroneous comments.
Mar 2 2018, 13:21

Mar 1 2018

tomtomtom7 updated the diff for D1117: Integrate UtxoCommitment in CCoinView.

Fix some logic error from the previous diff to D1117

Mar 1 2018, 10:35
tomtomtom7 updated the diff for D1117: Integrate UtxoCommitment in CCoinView.

Small refactoring to make it more clear

Mar 1 2018, 09:33

Feb 28 2018

tomtomtom7 updated the diff for D1117: Integrate UtxoCommitment in CCoinView.

Still WIP, But much better version.

Feb 28 2018, 23:46
tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Fix compile error in serialize methods

Feb 28 2018, 22:45
tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Add (de)serialialization methods

Feb 28 2018, 21:58
tomtomtom7 updated the diff for D1110: Add UTXO commitment contruction from UTXO cursor.

Change the combine constructor to an Add method.

Feb 28 2018, 15:59
tomtomtom7 added a comment to D1072: Add ECMH multiset module to libsecp256k1.

This still needs to build with cmake.

Feb 28 2018, 10:31
tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.
  • Fixed braces
  • Removed static from bench
  • Reordered references in readme
Feb 28 2018, 10:28

Feb 26 2018

tomtomtom7 added a comment to D1074: Add Utxo Commitment wrapper around libsecp256k1.

As a general comment, I am a bit juggling with the proper integration via CCoinViews. This may mean we need more changes to this wrapper class.

Feb 26 2018, 19:01

Feb 22 2018

tomtomtom7 updated the diff for D1117: Integrate UtxoCommitment in CCoinView.

Updated to try a more efficient approach with batching the delta

Feb 22 2018, 16:57
tomtomtom7 updated the summary of D1117: Integrate UtxoCommitment in CCoinView.
Feb 22 2018, 11:53
Herald added a reviewer for D1117: Integrate UtxoCommitment in CCoinView: Restricted Project.
Feb 22 2018, 11:51

Feb 21 2018

tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Include Clear() method

Feb 21 2018, 22:09

Feb 20 2018

tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Add cmake configuration

Feb 20 2018, 15:57
tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.

Fix in cmake file for multiset module

Feb 20 2018, 13:17
tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.

Enable multiset module in cmake configuration

Feb 20 2018, 12:50

Feb 19 2018

tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.

Add cmake switch for multiset module

Feb 19 2018, 21:13

Feb 16 2018

Herald added a reviewer for D1110: Add UTXO commitment contruction from UTXO cursor: Restricted Project.
Feb 16 2018, 15:29

Feb 13 2018

tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.

Add test vectors as included in the specification

Feb 13 2018, 15:11
tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.
  • Better align comment/indent styling
  • Fix test-failing typo in new hash-to-EC-point algorithm
  • Clarify reference to PDF as source of ECMH algorithm
  • Add more test comments
  • Add duplicate element tests
Feb 13 2018, 11:14

Feb 12 2018

tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.

Using suggested trial-and-hash algorithm with incrementing prefix

Feb 12 2018, 12:55

Feb 10 2018

tomtomtom7 added a comment to D1072: Add ECMH multiset module to libsecp256k1.

I am a bit uncertain about finalize. Is there actually a point in hashing?

Feb 10 2018, 15:35
tomtomtom7 added a comment to D1072: Add ECMH multiset module to libsecp256k1.

I have address some of the issues

Feb 10 2018, 15:29
tomtomtom7 updated the diff for D1072: Add ECMH multiset module to libsecp256k1.

Addressing some of the review comments

Feb 10 2018, 15:28

Feb 9 2018

tomtomtom7 added inline comments to D1074: Add Utxo Commitment wrapper around libsecp256k1.
Feb 9 2018, 22:08
tomtomtom7 updated the diff for D1074: Add Utxo Commitment wrapper around libsecp256k1.

Split CUtxoCommit in header and source file

Feb 9 2018, 21:05
tomtomtom7 updated the summary of D1074: Add Utxo Commitment wrapper around libsecp256k1.
Feb 9 2018, 21:05
Herald added a reviewer for D1074: Add Utxo Commitment wrapper around libsecp256k1: Restricted Project.
Feb 9 2018, 21:05
Herald added a reviewer for D1072: Add ECMH multiset module to libsecp256k1: Restricted Project.
Feb 9 2018, 21:05

Dec 7 2017

tomtomtom7 added a comment to D755: Start differenciating txid and txhash.

I am sorry for leaving this on table, but I must say I am bit disappointed about the procedure here.

Dec 7 2017, 11:22
tomtomtom7 abandoned D670: Refactoring GetId() to GetHash().
Dec 7 2017, 11:11
tomtomtom7 abandoned D671: Refactoring txid to txhash; mempool and validation.
Dec 7 2017, 11:05
tomtomtom7 abandoned D672: Refactoring txid to txhash; other core functions.
Dec 7 2017, 10:45
tomtomtom7 abandoned D707: Refactoring txid to txhash; wallet functionality.
Dec 7 2017, 09:59
tomtomtom7 abandoned D614: MalFix: Type separation of txids to txhash and unspentid.
Dec 7 2017, 09:28