Page MenuHomePhabricator

Add test/data directory to enable make check
AbandonedPublic

Authored by jasonbcox on Jun 24 2018, 14:42.

Details

Reviewers
deadalnix
tomtomtom7
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

This prevents make check from complaining about a non-exist
directory.

Test Plan

None. Only cmake effected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2763
Build 3636: Bitcoin ABC Buildbot (legacy)
Build 3635: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jun 24 2018, 14:42

Weird.

src/test/data/CMakeLists.txt
1

Should this be Bitcoin Cash developers now? @deadalnix

Can you explain what the problem was/is ?

On fresh checkout, "make check" after cmake fails because the directory "test/data" doesn't exists (at least on my config; I am a bit new to cmake):

git clone ...
mkdir build
cd build
cmake ..
make check
>> Error
deadalnix requested changes to this revision.Jun 30 2018, 23:48

Next time please make sure you report what the error actualy is. I had to run it all manually to figure out what you where running into.

src/test/CMakeLists.txt
39

If you are going to create that new folder, you should move the logic processing what's in it in the proper CMakeFile.txt

Alternatively, you can just add a command to make sure the folder exists in here.

This revision now requires changes to proceed.Jun 30 2018, 23:48
src/test/CMakeLists.txt
39

I am sorry but I am not quite sure how. The logic is processing files in src/test but using some files in src/test/data. So I can't really move it to test.

Alternatively, you can just add a command to make sure the folder exists in here.

Isn't that what I am doing? Is there a better way?

jasonbcox abandoned this revision.
jasonbcox added a reviewer: tomtomtom7.