This prevents make check from complaining about a non-exist
directory.
Details
Details
- Reviewers
deadalnix tomtomtom7 - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project
None. Only cmake effected.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2763 Build 3636: Bitcoin ABC Buildbot (legacy) Build 3635: arc lint + arc unit
Event Timeline
Comment Actions
Weird.
| src/test/data/CMakeLists.txt | ||
|---|---|---|
| 1 | Should this be Bitcoin Cash developers now? @deadalnix | |
Comment Actions
On fresh checkout, "make check" after cmake fails because the directory "test/data" doesn't exists (at least on my config; I am a bit new to cmake):
git clone ... mkdir build cd build cmake .. make check >> Error
Comment Actions
Next time please make sure you report what the error actualy is. I had to run it all manually to figure out what you where running into.
| src/test/CMakeLists.txt | ||
|---|---|---|
| 39 | If you are going to create that new folder, you should move the logic processing what's in it in the proper CMakeFile.txt Alternatively, you can just add a command to make sure the folder exists in here. | |
| src/test/CMakeLists.txt | ||
|---|---|---|
| 39 | I am sorry but I am not quite sure how. The logic is processing files in src/test but using some files in src/test/data. So I can't really move it to test.
Isn't that what I am doing? Is there a better way? | |