Page MenuHomePhabricator

Add unit tests for combining UTXO commitments.
AbandonedPublic

Authored by jasonbcox on Jun 11 2018, 16:35.

Details

Reviewers
tomtomtom7
matiu
ivan_s
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

As per title.

depends D1074

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
test-utxo-commitment
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2738
Build 3587: Bitcoin ABC Buildbot (legacy)
Build 3586: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jun 11 2018, 16:35
jasonbcox requested changes to this revision.Jun 12 2018, 23:23
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/utxocommit_tests.cpp
184 ↗(On Diff #4101)

This should be more explicit, like:

BOOST_CHECK(uc1 == CUtxoCommit())

This prevents changes in test behavior if uc3 is modified before this check.

186 ↗(On Diff #4101)

Comment the beginning of this block of code. Something similar to: Test utxo commitment equality

195 ↗(On Diff #4101)

Also comment here: Test clear behavior

This revision now requires changes to proceed.Jun 12 2018, 23:23

Improve test readability.

This revision is now accepted and ready to land.Jun 14 2018, 20:20
jasonbcox abandoned this revision.
jasonbcox edited reviewers, added: ivan_s; removed: jasonbcox.