Page MenuHomePhabricator
Differential D1495

Add unit tests for combining UTXO commitments.
AbandonedPublic
Actions

Authored by jasonbcox on Jun 11 2018, 16:35.

Details

Reviewers
tomtomtom7
matiu
ivan_s
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

As per title.

depends D1074

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
test-utxo-commitment
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2738
Build 3587: Bitcoin ABC Buildbot (legacy)
Build 3586: arc lint + arc unit

Event Timeline

ivan_s created this revision.Jun 11 2018, 16:35
Owners added a reviewer: Restricted Owners Package.Jun 11 2018, 16:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2018, 16:35
ivan_s edited the summary of this revision. (Show Details)Jun 11 2018, 16:37
teamcity added a subscriber: teamcity.Jun 11 2018, 16:37

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

matiu added a parent revision: D1074: Add Utxo Commitment wrapper around libsecp256k1.Jun 11 2018, 16:38
teamcity added a comment.Jun 11 2018, 17:14

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2728: Diff 4101.Jun 11 2018, 17:14
tomtomtom7 accepted this revision.Jun 11 2018, 19:07

Lookg good

jasonbcox requested changes to this revision.Jun 12 2018, 23:23
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/utxocommit_tests.cpp
184 ↗(On Diff #4101)

This should be more explicit, like:

BOOST_CHECK(uc1 == CUtxoCommit())

This prevents changes in test behavior if uc3 is modified before this check.

186 ↗(On Diff #4101)

Comment the beginning of this block of code. Something similar to: Test utxo commitment equality

195 ↗(On Diff #4101)

Also comment here: Test clear behavior

This revision now requires changes to proceed.Jun 12 2018, 23:23
ivan_s updated this revision to Diff 4119.Jun 13 2018, 18:12

Improve test readability.

teamcity added a comment.Jun 13 2018, 18:12

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 13 2018, 18:46

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2738: Diff 4119.Jun 13 2018, 18:46
jasonbcox accepted this revision.Jun 14 2018, 20:20
This revision is now accepted and ready to land.Jun 14 2018, 20:20
jasonbcox commandeered this revision.Apr 23 2019, 17:05
jasonbcox abandoned this revision.
jasonbcox mentioned this in D1074: Add Utxo Commitment wrapper around libsecp256k1.
jasonbcox edited reviewers, added: ivan_s; removed: jasonbcox.

Revision Contents
Changeset List

PathSize
src/
test/
31 lines

Diff 4119

View Options

src/test/utxocommit_tests.cpp

Loading...