Page MenuHomePhabricator
Differential D962

Prepare a flag for charging for excessive utxo creation
ClosedPublic
Actions

Authored by schancel on Jan 15 2018, 19:50.

Details

Reviewers
deadalnix
sickpig
Group Reviewers
Restricted Project
Maniphest Tasks
T300: Per UTXO Billing
Commits
rSTAGINGea91b58aac8b: Prepare a flag for charging for excessive utxo creation
rABCea91b58aac8b: Prepare a flag for charging for excessive utxo creation
Summary

As per title

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Jan 15 2018, 19:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2018, 19:50
schancel updated this revision to Diff 2530.Jan 15 2018, 20:03

Fix comment

sickpig added a comment.Jan 15 2018, 21:34

patch is still WIP right? cause I don't see any criteria on how to apply excessUTXOCharge

src/init.cpp
1495 ↗(On Diff #2530)

minrealytxfee ?

schancel updated this revision to Diff 2531.Jan 15 2018, 22:58

Fix copypasta

Harbormaster completed remote builds in B1626: Diff 2531.Jan 15 2018, 22:58
schancel added a child revision: D963: [WIP] Add fee for excessive utxo creation..Jan 16 2018, 00:43
teamcity added a subscriber: teamcity.Feb 6 2018, 02:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 6 2018, 03:17

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Feb 6 2018, 08:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Feb 6 2018, 08:41

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 6 2018, 08:48

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 6 2018, 09:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Feb 6 2018, 09:07

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Feb 6 2018, 17:41

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 6 2018, 18:00

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Feb 6 2018, 18:24

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 6 2018, 18:45

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix requested changes to this revision.Feb 28 2018, 13:00

This needs to a be a config parameter. Let's not add more globals.

This revision now requires changes to proceed.Feb 28 2018, 13:00
schancel updated this revision to Diff 3054.Mar 5 2018, 01:08

Move parameter to config

schancel updated this revision to Diff 3055.Mar 5 2018, 01:09

Remove extern variable

teamcity added a comment.Mar 5 2018, 02:37

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 5 2018, 02:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 5 2018, 02:56

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1979: Diff 3054.Mar 5 2018, 02:56
teamcity added a comment.Mar 5 2018, 02:59

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1980: Diff 3055.Mar 5 2018, 02:59
schancel added inline comments.Mar 5 2018, 16:48
src/validation.h
59 ↗(On Diff #3055)

excesseutxocharge is spelled wrong everywhere.

schancel updated this revision to Diff 3090.Mar 5 2018, 22:05

Rebase

schancel added a child revision: D1173: Remove mempool dependency on minRelayFee.Mar 5 2018, 23:34
teamcity added a comment.Mar 6 2018, 00:33

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 6 2018, 00:56

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2004: Diff 3090.Mar 6 2018, 00:56
schancel edited the summary of this revision. (Show Details)Mar 6 2018, 05:55
schancel updated this revision to Diff 3094.Mar 6 2018, 06:25

Rebase

teamcity added a comment.Mar 6 2018, 06:27

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 6 2018, 06:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2008: Diff 3094.Mar 6 2018, 06:52
deadalnix accepted this revision.Mar 6 2018, 14:31
This revision is now accepted and ready to land.Mar 6 2018, 14:31
schancel removed child revisions: D1173: Remove mempool dependency on minRelayFee, D963: [WIP] Add fee for excessive utxo creation..Mar 7 2018, 19:10
schancel removed a parent revision: D957: [WIP] Refactor priority calculation slightly for clarity.
schancel added a child revision: D963: [WIP] Add fee for excessive utxo creation..Mar 14 2018, 01:55
schancel mentioned this in T300: Per UTXO Billing.Mar 15 2018, 14:23
schancel added a task: T300: Per UTXO Billing.Mar 15 2018, 14:55
schancel updated this revision to Diff 3229.Mar 16 2018, 05:03

Add excessutxocharge to getnetworkinfo

teamcity added a comment.Mar 16 2018, 05:05

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2111: Diff 3229.Mar 16 2018, 05:29
teamcity added a comment.Mar 16 2018, 05:29

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Closed by commit rABCea91b58aac8b: Prepare a flag for charging for excessive utxo creation (authored by schancel). · Explain WhyApr 13 2018, 01:00
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in D14888: Remove unused excessUTXOCharge config option.Dec 1 2023, 09:42
PiRK mentioned this in rABC9725fe7b3c63: Remove unused excessUTXOCharge config option.Dec 4 2023, 06:59

Revision Contents
Changeset List

PathSize
src/
15 lines
8 lines
17 lines
rpc/
8 lines
2 lines

Diff 3497

View Options

src/config.h

Loading...
View Options

src/config.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/validation.h

Loading...