- Group Reviewers
- rABC59ee4dedf793: Add an RPC to finalize a block
rSTAGING59ee4dedf793: Add an RPC to finalize a block
|189 ↗||(On Diff #5866)|
ancstor -> ancestor
|1515 ↗||(On Diff #5866)|
block -> this block otherwise it sounds ambiguous
|1516 ↗||(On Diff #5866)|
Add to the end: USE WITH CAUTION!
|1520 ↗||(On Diff #5866)|
mostpreciousblock -> finalizeblock
|2204 ↗||(On Diff #5866)|
This seems counter to the goal of the diff. DisconnectTip() is called from ActivateBestChainStep(), so doesn't that allow finalized blocks to be reorg'd?
|2405 ↗||(On Diff #5867)|
past -> prior to since "past" sounds like a block that is coming after the finalized block
|3562 ↗||(On Diff #5867)|
The changes below this line can go in their own diff and be landed on master. Please do this to make this diff smaller and allow others to work on the code that is most improved.
|70 ↗||(On Diff #5867)|
Shouldn't this log be up one line? the assert_equal has already checked that node and alt_node have the same chaintips.