Page MenuHomePhabricator
Differential D2106

Add test case and release notes for auto finalization
ClosedPublic
Actions

Authored by deadalnix on Nov 20 2018, 01:45.

Details

Reviewers
schancel
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGd1d091ba73f5: Add test case and release notes for auto finalization
rABCd1d091ba73f5: Add test case and release notes for auto finalization
Summary

As per title.

Depends on D2102

Test Plan
make check
./test/functional/test_runner.py abc-finalize-block

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Nov 20 2018, 01:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2018, 01:45
deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 20 2018, 01:45
deadalnix edited the test plan for this revision. (Show Details)
schancel accepted this revision.Nov 20 2018, 01:48
This revision is now accepted and ready to land.Nov 20 2018, 01:48
schancel added inline comments.Nov 20 2018, 01:50
test/functional/abc-finalize-block.py
57 ↗(On Diff #5953)

Please assert this again here.

assert_equal(node.getbestblockhash(), tip)
deadalnix updated this revision to Diff 5954.Nov 20 2018, 01:52

Add assertion

jasonbcox added a subscriber: jasonbcox.Nov 20 2018, 01:57
jasonbcox added inline comments.
doc/release-notes.md
9 ↗(On Diff #5953)

penality -> penalty

alternatives chain -> alternative chains

deadalnix updated this revision to Diff 5955.Nov 20 2018, 01:58

Update release notes

jasonbcox accepted this revision.Nov 20 2018, 01:59
Closed by commit rABCd1d091ba73f5: Add test case and release notes for auto finalization (authored by deadalnix). · Explain WhyNov 20 2018, 16:47
This revision was automatically updated to reflect the committed changes.
deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 21 2018, 13:29

Revision Contents
Changeset List

Diff 5960

View Options

doc/release-notes.md

Loading...
View Options

test/functional/abc-finalize-block.py

Loading...