Page MenuHomePhabricator

[avalanche] Add a facility to select invs to poll
ClosedPublic

Authored by deadalnix on Nov 11 2018, 15:38.

Details

Summary

This extends the AvalancheProcessor with facility to decide what to poll.

Depends on D2043

Test Plan

Added unit tests.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Nov 11 2018, 15:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2018, 15:38
deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 11 2018, 17:29
deadalnix updated this revision to Diff 5751.Nov 11 2018, 21:06

addBlockToReconciliate => addBlockToReconcile

jasonbcox accepted this revision.Nov 11 2018, 23:33
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/avalanche.cpp
65 ↗(On Diff #5751)

Does this need a static_assert() to ensure it's strictly less than MAX_INV_SZ?

This revision is now accepted and ready to land.Nov 11 2018, 23:33
Fabien added a subscriber: Fabien.Nov 12 2018, 16:11

Can you rebase ?

schancel accepted this revision.Nov 12 2018, 21:15
jasonbcox requested changes to this revision.Nov 13 2018, 03:43
jasonbcox added inline comments.
src/avalanche.cpp
65 ↗(On Diff #5751)

The more I look at the other changes, the more important I think this is. Either strictly less than MAX_INV_SZ or dependent on MAX_PROTOCOL_MESSAGE_LENGTH in some way.

This revision now requires changes to proceed.Nov 13 2018, 03:43
deadalnix requested review of this revision.Nov 13 2018, 03:46
deadalnix marked an inline comment as done.
deadalnix added inline comments.
src/avalanche.cpp
65 ↗(On Diff #5751)

No. This is fast protocol, we want a low limit.

jasonbcox added inline comments.Nov 13 2018, 22:57
src/avalanche.cpp
65 ↗(On Diff #5751)

Ok, as long as we expect it to always be way lower.

Fabien accepted this revision as: Fabien.Nov 17 2018, 15:27
deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 21 2018, 13:28
deadalnix updated this revision to Diff 5976.Nov 21 2018, 14:01

wrong diff

deadalnix updated this revision to Diff 6001.Nov 21 2018, 23:47

remove unecessary code

Fabien accepted this revision.Nov 22 2018, 18:58
This revision is now accepted and ready to land.Nov 22 2018, 18:59
This revision was automatically updated to reflect the committed changes.