Page MenuHomePhabricator
Differential D2102

Auto-finalize block once they reached a certain depth (by default 10)
ClosedPublic
Actions

Authored by deadalnix on Nov 19 2018, 14:18.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING917d65774c40: Auto-finalize block once they reached a certain depth (by default 10)
rABC917d65774c40: Auto-finalize block once they reached a certain depth (by default 10)
Summary

This ensures that deep reorg are not possible.

Can be controlled by the -maxreorgdepth parameter. Set to -1 to disable.

Depends on D2083

Test Plan

Added an integration test.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 19 2018, 14:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2018, 14:18
deadalnix edited the summary of this revision. (Show Details)Nov 19 2018, 14:18
deadalnix added a parent revision: D2083: Add an RPC to finalize a block.
teamcity added a subscriber: teamcity.Nov 19 2018, 14:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 19 2018, 14:27
deadalnix updated this revision to Diff 5951.Nov 19 2018, 18:02

rebase

jasonbcox requested changes to this revision.Nov 19 2018, 18:16
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.h
99 ↗(On Diff #5951)

Move this and the above nits to another diff.

This revision now requires changes to proceed.Nov 19 2018, 18:16
jasonbcox added a comment.Nov 19 2018, 18:19

Needs a test that at least covers default 10-block finalization behavior.

deadalnix added a child revision: D2106: Add test case and release notes for auto finalization.Nov 20 2018, 01:45
jasonbcox accepted this revision.Nov 20 2018, 16:31
This revision is now accepted and ready to land.Nov 20 2018, 16:31
Closed by commit rABC917d65774c40: Auto-finalize block once they reached a certain depth (by default 10) (authored by deadalnix). · Explain WhyNov 20 2018, 16:32
This revision was automatically updated to reflect the committed changes.
deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 21 2018, 13:29

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines
14 lines
63 lines
test/
functional/
2 lines
4 lines
3 lines
26 lines
152 lines

Diff 5959

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-parkedchain.py

Loading...
View Options

test/functional/bip68-sequence.py

Loading...
View Options

test/functional/p2p-fullblocktest.py

Loading...
View Options

test/functional/pruning.py

Loading...
View Options

test/functional/timing.json

Loading...