Page MenuHomePhabricator

Auto-finalize block once they reached a certain depth (by default 10)
ClosedPublic

Authored by deadalnix on Mon, Nov 19, 14:18.

Details

Summary

This ensures that deep reorg are not possible.

Can be controlled by the -maxreorgdepth parameter. Set to -1 to disable.

Depends on D2083

Test Plan

Added an integration test.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Mon, Nov 19, 14:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 19, 14:18
deadalnix edited the summary of this revision. (Show Details)Mon, Nov 19, 14:18
deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Mon, Nov 19, 14:27
jasonbcox requested changes to this revision.Mon, Nov 19, 18:16
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.h
99 ↗(On Diff #5951)

Move this and the above nits to another diff.

This revision now requires changes to proceed.Mon, Nov 19, 18:16

Needs a test that at least covers default 10-block finalization behavior.

jasonbcox accepted this revision.Tue, Nov 20, 16:31
This revision is now accepted and ready to land.Tue, Nov 20, 16:31
This revision was automatically updated to reflect the committed changes.
deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Wed, Nov 21, 13:29