Page MenuHomePhabricator

Auto-finalize block once they reached a certain depth (by default 10)

Authored by deadalnix on Nov 19 2018, 14:18.



This ensures that deep reorg are not possible.

Can be controlled by the -maxreorgdepth parameter. Set to -1 to disable.

Depends on D2083

Test Plan

Added an integration test.

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 19 2018, 14:27
jasonbcox requested changes to this revision.Nov 19 2018, 18:16
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
99 ↗(On Diff #5951)

Move this and the above nits to another diff.

This revision now requires changes to proceed.Nov 19 2018, 18:16

Needs a test that at least covers default 10-block finalization behavior.

This revision is now accepted and ready to land.Nov 20 2018, 16:31
This revision was automatically updated to reflect the committed changes.
deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 21 2018, 13:29