Page MenuHomePhabricator

[avalanche] Use a multi_index to track request so it is easy to determine which timed out.
ClosedPublic

Authored by deadalnix on Nov 26 2018, 20:45.

Details

Summary

As per title. This also adds the requirement that an avaresponse needs to return the round it is responding to. This ensure it is possible to have several queries in flight for a given node if we want to.

Depends on D2122

Test Plan

Updated unit tests accordingly.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Nov 26 2018, 20:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2018, 20:45
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox requested changes to this revision.Nov 26 2018, 21:15
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/avalanche.h
132 ↗(On Diff #6112)

What is this and what is it for?

This revision now requires changes to proceed.Nov 26 2018, 21:15
Fabien requested changes to this revision.Nov 27 2018, 15:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche.h
15 ↗(On Diff #6112)

This requires an update in the build documentation build-unix.md:
in section "Dependency Build Instructions : Ubuntu & Debian" add libboost-serialization-dev to the list of the required boost library files.

deadalnix marked an inline comment as done.Nov 28 2018, 12:52
deadalnix requested review of this revision.
deadalnix added inline comments.
src/avalanche.h
15 ↗(On Diff #6112)

It's not required. multi_index is already used in the mempool with no problem.

deadalnix updated this revision to Diff 6152.Nov 28 2018, 12:56

Remove the whatever field

Fabien accepted this revision as: Fabien.Nov 28 2018, 13:12
jasonbcox accepted this revision.Nov 28 2018, 18:44
This revision is now accepted and ready to land.Nov 28 2018, 18:44
This revision was automatically updated to reflect the committed changes.