Page MenuHomePhabricator

[avalanche] Expire queries once they reached their timeout.
ClosedPublic

Authored by deadalnix on Tue, Nov 27, 15:29.

Details

Summary

So far, AvalancheProcessor leaks when a peer timesout. This ensures that queries that times out are effectively cleared with each event loop.

Depends on D2140

Test Plan

Added a test case.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Tue, Nov 27, 15:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 27, 15:29
Herald added a subscriber: schancel. · View Herald Transcript
Fabien added a subscriber: Fabien.Tue, Nov 27, 17:23
Fabien added inline comments.
src/test/avalanche_tests.cpp
515 ↗(On Diff #6131)

soltuion => solution

Fabien accepted this revision as: Fabien.Tue, Nov 27, 17:24

LGTM with nit

This revision is now accepted and ready to land.Tue, Nov 27, 17:24
deadalnix updated this revision to Diff 6153.Wed, Nov 28, 15:30

rebase and fix typo

This revision was automatically updated to reflect the committed changes.