Page MenuHomePhabricator
Differential D2143

[avalanche] Expire queries once they reached their timeout.
ClosedPublic
Actions

Authored by deadalnix on Nov 27 2018, 15:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING49f8c721b92b: [avalanche] Expire queries once they reached their timeout.
rABC49f8c721b92b: [avalanche] Expire queries once they reached their timeout.
Summary

So far, AvalancheProcessor leaks when a peer timesout. This ensures that queries that times out are effectively cleared with each event loop.

Depends on D2140

Test Plan

Added a test case.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avaquerytimeout
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4167
Build 6400: Bitcoin ABC Buildbot (legacy)
Build 6399: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 27 2018, 15:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2018, 15:29
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Nov 27 2018, 15:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 27 2018, 15:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4144: Diff 6131.Nov 27 2018, 15:40
Fabien added a subscriber: Fabien.Nov 27 2018, 17:23
Fabien added inline comments.
src/test/avalanche_tests.cpp
515 ↗(On Diff #6131)

soltuion => solution

Fabien accepted this revision as: Fabien.Nov 27 2018, 17:24

LGTM with nit

This revision is now accepted and ready to land.Nov 27 2018, 17:24
deadalnix updated this revision to Diff 6153.Nov 28 2018, 15:30

rebase and fix typo

teamcity added a comment.Nov 28 2018, 15:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 28 2018, 15:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4159: Diff 6153.Nov 28 2018, 15:42
deadalnix updated this revision to Diff 6164.Nov 29 2018, 15:19

rebase

teamcity added a comment.Nov 29 2018, 15:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 29 2018, 15:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4167: Diff 6164.Nov 29 2018, 15:27
Closed by commit rABC49f8c721b92b: [avalanche] Expire queries once they reached their timeout. (authored by deadalnix). · Explain WhyNov 29 2018, 17:39
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
14 lines
13 lines
test/
22 lines

Diff 6164

View Options

src/avalanche.h

Loading...
View Options

src/avalanche.cpp

Loading...
View Options

src/test/avalanche_tests.cpp

Loading...