Page MenuHomePhabricator

Add test case and release notes for auto finalization
ClosedPublic

Authored by deadalnix on Nov 20 2018, 01:45.

Details

Summary

As per title.

Depends on D2102

Test Plan
make check
./test/functional/test_runner.py abc-finalize-block

Diff Detail

Repository
rABC Bitcoin ABC
Branch
autofinalizetest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4009
Build 6090: Bitcoin ABC Buildbot (legacy)
Build 6089: arc lint + arc unit

Event Timeline

deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 20 2018, 01:45
deadalnix edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Nov 20 2018, 01:48
test/functional/abc-finalize-block.py
57 ↗(On Diff #5953)

Please assert this again here.

assert_equal(node.getbestblockhash(), tip)
jasonbcox added inline comments.
doc/release-notes.md
9 ↗(On Diff #5953)

penality -> penalty

alternatives chain -> alternative chains

This revision was automatically updated to reflect the committed changes.
deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 21 2018, 13:29