Details
- Reviewers
schancel jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING59ee4dedf793: Add an RPC to finalize a block
rABC59ee4dedf793: Add an RPC to finalize a block
./test/functional/test_runner.py abc-finalize-block
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- finalizeblock
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3942 Build 5956: Bitcoin ABC Buildbot (legacy) Build 5955: arc lint + arc unit
Event Timeline
| test/functional/abc-finalize-block.py | ||
|---|---|---|
| 76 ↗ | (On Diff #5866) | Should this fail there doesn't seem to be able assertion here? |
| test/functional/abc-finalize-block.py | ||
|---|---|---|
| 76 ↗ | (On Diff #5866) | Ho yes, correct. |
| src/chain.cpp | ||
|---|---|---|
| 189 ↗ | (On Diff #5866) | ancstor -> ancestor |
| src/rpc/blockchain.cpp | ||
| 1515 ↗ | (On Diff #5866) | block -> this block otherwise it sounds ambiguous |
| 1516 ↗ | (On Diff #5866) | Add to the end: USE WITH CAUTION! |
| 1520 ↗ | (On Diff #5866) | mostpreciousblock -> finalizeblock |
| src/validation.cpp | ||
| 2204 ↗ | (On Diff #5866) | This seems counter to the goal of the diff. DisconnectTip() is called from ActivateBestChainStep(), so doesn't that allow finalized blocks to be reorg'd? |
| src/validation.cpp | ||
|---|---|---|
| 2204 ↗ | (On Diff #5866) | You can only do this via RPC. FindMostWorkChain will not pick that chain. Keeping the finalized block on an invalid chain effectively brick the node. |
| src/validation.cpp | ||
|---|---|---|
| 2405 ↗ | (On Diff #5867) | past -> prior to since "past" sounds like a block that is coming after the finalized block |
| 3562 ↗ | (On Diff #5867) | The changes below this line can go in their own diff and be landed on master. Please do this to make this diff smaller and allow others to work on the code that is most improved. |
| test/functional/abc-finalize-block.py | ||
| 70 ↗ | (On Diff #5867) | Shouldn't this log be up one line? the assert_equal has already checked that node and alt_node have the same chaintips. |
| src/validation.cpp | ||
|---|---|---|
| 2204 ↗ | (On Diff #5866) | Ok. Just double checking this was thought through. I see the check in FindMostWorkChain(). |
| test/functional/abc-finalize-block.py | ||
|---|---|---|
| 70 ↗ | (On Diff #5867) | And once we finalize, we reorg into the chain that is finalized. |
| test/functional/abc-finalize-block.py | ||
|---|---|---|
| 70 ↗ | (On Diff #5867) | Oh I see. |
| src/validation.cpp | ||
|---|---|---|
| 2388 | Was it something we need to have done independently from the change introduced in this diff? | |
| src/validation.cpp | ||
|---|---|---|
| 2388 | Just checking existing invariants. | |