Page MenuHomePhabricator

Use bitcoin's serialization and uint256 implementation in the seeder.
ClosedPublic

Authored by deadalnix on Sep 26 2017, 22:01.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 26 2017, 22:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2017, 22:01
deadalnix updated this revision to Diff 1425.Sep 27 2017, 09:47

Fix the build.

sickpig added a subscriber: sickpig.Sep 27 2017, 13:25

nice addition

schancel edited edge metadata.EditedSep 30 2017, 18:25
In file included from ./seeder/netbase.h:8:
./serialize.h:553:6: error: member reference base type 'const long' is not a structure or union
    a.Serialize(os);
    ~^~~~~~~~~~

And

./serialize.h:558:6: error: member reference base type 'long' is not a structure or union
    a.Unserialize(is);
schancel accepted this revision.Oct 3 2017, 02:49

I'm still unable to compile this on a mac, but this does remove some warnings. I'll look at fixing the two remaining errors as soon as I can.

This revision is now accepted and ready to land.Oct 3 2017, 02:49
This revision was automatically updated to reflect the committed changes.