Details

Reviewers

schancel
freetrader
dagurval

Group Reviewers

Restricted Project

Commits

rSTAGING5f79273a74db: Use bitcoin's serialization and uint256 implementation in the seeder.
rABC5f79273a74db: Use bitcoin's serialization and uint256 implementation in the seeder.

Summary

As per title.

Test Plan

Build and run the seeder.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 26 2017, 22:01

Harbormaster completed remote builds in B897: Diff 1421.Sep 26 2017, 22:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2017, 22:01

Fix the build.

Harbormaster completed remote builds in B900: Diff 1425.Sep 27 2017, 09:47

nice addition

sickpig mentioned this in D561: Use cstdint in seeder.Sep 28 2017, 09:16

In file included from ./seeder/netbase.h:8:
./serialize.h:553:6: error: member reference base type 'const long' is not a structure or union
    a.Serialize(os);
    ~^~~~~~~~~~

And

./serialize.h:558:6: error: member reference base type 'long' is not a structure or union
    a.Unserialize(is);

Rebase

Harbormaster completed remote builds in B929: Diff 1468.Oct 1 2017, 09:38

I'm still unable to compile this on a mac, but this does remove some warnings. I'll look at fixing the two remaining errors as soon as I can.

This revision is now accepted and ready to land.Oct 3 2017, 02:49

Closed by commit rABC5f79273a74db: Use bitcoin's serialization and uint256 implementation in the seeder. (authored by deadalnix, committed by deadalnix). · Explain WhyOct 3 2017, 08:58

This revision was automatically updated to reflect the committed changes.

Use bitcoin's serialization and uint256 implementation in the seeder.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1476

src/Makefile.am

src/seeder/bitcoin.cpp

src/seeder/db.h

src/seeder/main.cpp

src/seeder/netbase.h

src/seeder/protocol.h

src/seeder/protocol.cpp

src/seeder/serialize.h

src/seeder/uint256.h

Use bitcoin's serialization and uint256 implementation in the seeder.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1476

src/Makefile.am

src/seeder/bitcoin.cpp

src/seeder/db.h

src/seeder/main.cpp

src/seeder/netbase.h

src/seeder/protocol.h

src/seeder/protocol.cpp

src/seeder/serialize.h

src/seeder/uint256.h

Use bitcoin's serialization and uint256 implementation in the seeder.
ClosedPublic
Actions

Revision Contents
Changeset List