Page MenuHomePhabricator

Use cstdint in seeder
ClosedPublic

Authored by deadalnix on Sep 26 2017, 21:13.

Details

Summary

As per title. no need to define a ton of custom types.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 26 2017, 21:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2017, 21:13
sickpig requested changes to this revision.Sep 27 2017, 13:43
sickpig added a subscriber: sickpig.
sickpig added inline comments.
src/seeder/serialize.h
264 ↗(On Diff #1418)

unsigned int ?

This revision now requires changes to proceed.Sep 27 2017, 13:43
deadalnix added inline comments.Sep 27 2017, 16:15
src/seeder/serialize.h
264 ↗(On Diff #1418)

What about it ?

deadalnix requested review of this revision.Sep 27 2017, 19:59
deadalnix edited edge metadata.
sickpig added inline comments.Sep 28 2017, 09:16
src/seeder/serialize.h
264 ↗(On Diff #1418)

never mind, serializing will be refactored in D564

sickpig accepted this revision.Sep 28 2017, 09:16
This revision is now accepted and ready to land.Sep 28 2017, 09:16
This revision was automatically updated to reflect the committed changes.