Page MenuHomePhabricator
Differential D561

Use cstdint in seeder
ClosedPublic
Actions

Authored by deadalnix on Sep 26 2017, 21:13.

Details

Reviewers
freetrader
schancel
dagurval
sickpig
Group Reviewers
Restricted Project
Commits
rSTAGING4cfdd00d89f5: Use cstdint in seeder
rABC4cfdd00d89f5: Use cstdint in seeder
Summary

As per title. no need to define a ton of custom types.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
uint64
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 894
Build 894: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 26 2017, 21:13
Harbormaster completed remote builds in B894: Diff 1418.Sep 26 2017, 21:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2017, 21:13
sickpig requested changes to this revision.Sep 27 2017, 13:43
sickpig added a subscriber: sickpig.
sickpig added inline comments.
src/seeder/serialize.h
264

unsigned int ?

This revision now requires changes to proceed.Sep 27 2017, 13:43
deadalnix added inline comments.Sep 27 2017, 16:15
src/seeder/serialize.h
264

What about it ?

deadalnix requested review of this revision.Sep 27 2017, 19:59
deadalnix edited edge metadata.
sickpig added inline comments.Sep 28 2017, 09:16
src/seeder/serialize.h
264

never mind, serializing will be refactored in D564

sickpig accepted this revision.Sep 28 2017, 09:16
This revision is now accepted and ready to land.Sep 28 2017, 09:16
Closed by commit rABC4cfdd00d89f5: Use cstdint in seeder (authored by deadalnix, committed by deadalnix). · Explain WhySep 28 2017, 19:50
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
seeder/
16 lines
12 lines
2 lines
2 lines
2 lines
4 lines
2 lines
112 lines
44 lines

Diff 1418

View Options

src/seeder/bitcoin.cpp

Loading...
View Options

src/seeder/db.h

Loading...
View Options

src/seeder/db.cpp

Loading...
View Options

src/seeder/main.cpp

Loading...
View Options

src/seeder/netbase.h

Loading...
View Options

src/seeder/netbase.cpp

Loading...
View Options

src/seeder/protocol.h

Loading...
View Options

src/seeder/serialize.h

Loading...
View Options

src/seeder/uint256.h

Loading...