Page MenuHomePhabricator
Differential D1449

Add src/test/buildenv.py to .gitignore
AbandonedPublic
Actions

Authored by sickpig on May 24 2018, 12:05.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Summary

see title

Test Plan

try to git-add src/test/buildenv.py . the command should add rise an error along with a message similar to this one:
The following paths are ignored by one of your .gitignore files:
src/test/buildenv.py
Use -f if you really want to add them.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gitignore (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2635
Build 3384: Bitcoin ABC Buildbot (legacy)
Build 3383: arc lint + arc unit

Event Timeline

sickpig created this revision.May 24 2018, 12:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2018, 12:05
teamcity added a subscriber: teamcity.May 24 2018, 12:07

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 24 2018, 12:41

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2630: Diff 3958.May 24 2018, 12:41
deadalnix added a comment.May 24 2018, 13:32

What is this file, why do we want to ignore it ?

sickpig updated this revision to Diff 3963.May 24 2018, 13:43

Format comment

teamcity added a comment.May 24 2018, 13:43

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

sickpig added a comment.May 24 2018, 13:47

last change wasn't supposed to update this diff.. fixing

sickpig updated this revision to Diff 3965.May 24 2018, 13:54

remove a spurios commit

teamcity added a comment.May 24 2018, 13:54

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 24 2018, 14:18

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2633: Diff 3963.May 24 2018, 14:18
sickpig added a comment.May 24 2018, 14:25
In D1449#29299, @deadalnix wrote:

What is this file, why do we want to ignore it ?

It is generated by make check and it's an helper file that contains the extension to be used for binaries aiding the execution of the unit tests. When you run on Linux it's content is something like:

 #!/usr/bin/python
exeext=""

whereas when you're cross compiling for win32/64:

#!/usr/bin/python
exeext="exe"
teamcity added a comment.May 24 2018, 14:31

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2635: Diff 3965.May 24 2018, 14:31
schancel added a comment.May 24 2018, 21:32

I've never seen this file. My build generates test/config.ini which is read by the test harness. I'm fairly sure this is legacy -- we backported a commit a long time ago related to this.

sickpig abandoned this revision.May 25 2018, 07:22

​src/test/buildenv.py has been generated by an old in-tree build from late 2017, it is not used anymore. sorry for the noise.

Revision Contents
Changeset List

PathSize
1 line

Diff 3965

View Options

.gitignore

Loading...