Page MenuHomePhabricator
Differential D970

Skip rpcbind_test if OS/network requirements are not met.
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2018, 14:51.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING763a848ccf64: Skip rpcbind_test if OS/network requirements are not met.
rABC763a848ccf64: Skip rpcbind_test if OS/network requirements are not met.
Summary

Backport core's PR10053

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 17 2018, 14:51
Harbormaster completed remote builds in B1640: Diff 2557.Jan 17 2018, 14:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2018, 14:51
Herald added a reviewer: Restricted Project. · View Herald Transcript
deadalnix added a child revision: D971: [tests] skipped tests should clean up after themselves.Jan 17 2018, 15:06
sickpig added a subscriber: sickpig.Jan 17 2018, 15:08
sickpig added inline comments.
test/functional/test_runner.py
263 ↗(On Diff #2557)

isn't this change unrelated.
We can live that I suppose but still.

deadalnix added inline comments.Jan 17 2018, 15:14
test/functional/test_runner.py
263 ↗(On Diff #2557)

It comes from 0c1ade6a4b3921da6f8f2b17c8fc23e15edef426 which is in that PR. I assume the goal is that the test can be passed or skipped.

sickpig added inline comments.Jan 17 2018, 15:25
test/functional/test_runner.py
263 ↗(On Diff #2557)

I see.

then the change was unrelated also in the core commit cause it will just correct an error in the header of the result coverage table at the the end of the run.

previously the header for the result column was erroneously named "PASSED"

schancel accepted this revision.Jan 17 2018, 16:15
schancel added a subscriber: schancel.
schancel added inline comments.
test/functional/test_runner.py
263 ↗(On Diff #2557)

Gar

This revision is now accepted and ready to land.Jan 17 2018, 16:15
Closed by commit rABC763a848ccf64: Skip rpcbind_test if OS/network requirements are not met. (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyJan 17 2018, 16:48
This revision was automatically updated to reflect the committed changes.
schancel mentioned this in T142: Backport Core PR 10053: Allow functional test skipping.Jan 20 2018, 20:05

Revision Contents
Changeset List

PathSize
test/
functional/
24 lines
2 lines

Diff 2560

View Options

test/functional/rpcbind_test.py

Loading...
View Options

test/functional/test_runner.py

Loading...