Page MenuHomePhabricator

Fix PYTHONPATH export association in Makefile.am
ClosedPublic

Authored by freetrader on Sep 15 2017, 20:04.

Details

Summary

This fixes a build problem on FreeBSD which was raised by /u/1s44c in [1].
The problem with the original code that the "export PYTHONPATH" is
interpreted by gmake as an improperly indented command for the preceding
target.

Indentation, while it would surmounting the immediate build problem on FreeBSD,
is not the correct solution, since the export is intended to apply to further
command sequences and not to be a associated to the particular target
listed above it.

Accordingly, it is moved up which has been verified by inspection to result
in a clean Makefile on FreeBSD and Linux.

[1] https://np.reddit.com/r/BitcoinABC/comments/6yuy53/bitcoin_abc_ubuntu_repo_has_been_updated_to_serve/dms6ip3/

Test Plan

Test fix on FreeBSD by building from scratch (from autogen.sh thru rpc-tests)
Check Travis builds are all OK
Check Gitian builds are all OK
(if possible: OSX native build from scratch)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

freetrader created this revision.Sep 15 2017, 20:04
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptSep 15 2017, 20:04

Test results:

Gitian is still in progress, and to check on native OSX would need @CCulianu 's help...

freetrader edited the summary of this revision. (Show Details)Sep 15 2017, 20:20
deadalnix accepted this revision.Sep 15 2017, 23:22
This revision is now accepted and ready to land.Sep 15 2017, 23:22
This revision was automatically updated to reflect the committed changes.