Page MenuHomePhabricator
Differential D582

Build C code in seeder with PIE_FLAGS
ClosedPublic
Actions

Authored by freetrader on Oct 4 2017, 20:50.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING097f88c4566d: Build C code in seeder with PIE_FLAGS
rABC097f88c4566d: Build C code in seeder with PIE_FLAGS
Summary

This avoids a relocation error for libbitcoin_seeder_a-dns.o when building
the seeder shared library on some Debian environments (rare).

The build problem was observed on Debian 8 x86_64 derivate with gcc 7.1.0:

/usr/bin/ld: libbitcoin_seeder.a(libbitcoin_seeder_a-dns.o): relocation R_X86_64_32 against '.rodata' can not be used when making a shared object; recompile with -fPIC

Depends D581 .

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

freetrader created this revision.Oct 4 2017, 20:50
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptOct 4 2017, 20:50
Harbormaster completed remote builds in B942: Diff 1488.Oct 4 2017, 20:50
deadalnix requested changes to this revision.Oct 5 2017, 12:47
deadalnix added inline comments.
src/Makefile.am
28 ↗(On Diff #1488)

That's definitively not an include flag.

This revision now requires changes to proceed.Oct 5 2017, 12:47
freetrader updated this revision to Diff 1496.Oct 5 2017, 14:29
freetrader edited edge metadata.

Move PIE_FLAGS to more appropriate location

Harbormaster completed remote builds in B948: Diff 1496.Oct 5 2017, 14:29
deadalnix requested changes to this revision.Oct 5 2017, 15:08

I don't think this even builds...

src/Makefile.am
28 ↗(On Diff #1496)

fix

This revision now requires changes to proceed.Oct 5 2017, 15:08
freetrader updated this revision to Diff 1497.Oct 5 2017, 15:30
freetrader edited edge metadata.

Fix dropped parenthesis

Harbormaster completed remote builds in B949: Diff 1497.Oct 5 2017, 15:30
deadalnix accepted this revision.Oct 5 2017, 21:01
This revision is now accepted and ready to land.Oct 5 2017, 21:01
Closed by commit rABC097f88c4566d: Build C code in seeder with PIE_FLAGS (authored by freetrader, committed by freetrader). · Explain WhyOct 5 2017, 23:31
This revision was automatically updated to reflect the committed changes.
dagurval mentioned this in D797: Introduce bitcoinUriScheme.Dec 13 2017, 16:26

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 1499

View Options

src/Makefile.am

Loading...