Details

Reviewers

deadalnix
kyuupichan

Group Reviewers

Restricted Project

Commits

rSTAGING2bc42bd0ca41: Comment, cast and assert cleanup in pow.cpp
rABC2bc42bd0ca41: Comment, cast and assert cleanup in pow.cpp

Summary

Comments improved and a superfluous assert which is
covered by subsequent code is removed

Test Plan

make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

freetrader created this revision.Nov 4 2017, 20:19

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptNov 4 2017, 20:19

Harbormaster completed remote builds in B1049: Diff 1640.Nov 4 2017, 20:19

Fix up the commenting that the lint auto-adjusted

Formatting was still bad, fix

Harbormaster completed remote builds in B1051: Diff 1642.Nov 4 2017, 20:25

Another grammar fix

Harbormaster completed remote builds in B1052: Diff 1643.Nov 4 2017, 20:26

Explicit conversion to int64_t

freetrader retitled this revision from Comment and assert cleanup in pow.cpp to Comment, cast and assert cleanup in pow.cpp.Nov 4 2017, 22:53

freetrader edited the test plan for this revision. (Show Details)

Looks good to me.

This revision is now accepted and ready to land.Nov 5 2017, 03:10

Closed by commit rABC2bc42bd0ca41: Comment, cast and assert cleanup in pow.cpp (authored by freetrader). · Explain WhyNov 5 2017, 10:14

This revision was automatically updated to reflect the committed changes.

Comment, cast and assert cleanup in pow.cpp
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1645

src/pow.cpp

Comment, cast and assert cleanup in pow.cppClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1645

src/pow.cpp

Comment, cast and assert cleanup in pow.cpp
ClosedPublic
Actions

Revision Contents
Changeset List