Page MenuHomePhabricator

Comment, cast and assert cleanup in pow.cpp
ClosedPublic

Authored by freetrader on Nov 4 2017, 20:19.

Details

Summary

Comments improved and a superfluous assert which is
covered by subsequent code is removed

Test Plan

make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pow_cpp_comment_fixups
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1049
Build 1049: arc lint + arc unit

Event Timeline

freetrader created this revision.Nov 4 2017, 20:19
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptNov 4 2017, 20:19
freetrader updated this revision to Diff 1641.Nov 4 2017, 20:22

Fix up the commenting that the lint auto-adjusted

freetrader updated this revision to Diff 1642.Nov 4 2017, 20:25

Formatting was still bad, fix

freetrader updated this revision to Diff 1643.Nov 4 2017, 20:26

Another grammar fix

freetrader updated this revision to Diff 1644.Nov 4 2017, 22:30

Explicit conversion to int64_t

freetrader retitled this revision from Comment and assert cleanup in pow.cpp to Comment, cast and assert cleanup in pow.cpp.Nov 4 2017, 22:53
freetrader edited the test plan for this revision. (Show Details)
kyuupichan accepted this revision.Nov 5 2017, 03:10

Looks good to me.

This revision is now accepted and ready to land.Nov 5 2017, 03:10
This revision was automatically updated to reflect the committed changes.