Page MenuHomePhabricator

Update the chain paramaters.
ClosedPublic

Authored by deadalnix on Dec 2 2017, 01:08.

Details

Summary

As per title. Add the DAA activation as a checkpoint and update other parameters.

Test Plan

Do IBD for testnet and mainet.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Dec 2 2017, 01:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2017, 01:08
schancel added inline comments.Dec 4 2017, 00:22
src/chainparams.cpp
140 ↗(On Diff #1910)

I thought we wanted to do this after the fork date? This looks like it is before it.

freetrader added inline comments.
src/chainparams.cpp
250 ↗(On Diff #1910)

We should come up with some Cash chain (post fork) data for this.
It is used to estimate the progress afaik, and is quite outdated.

Mengerian accepted this revision.Dec 4 2017, 15:23
Mengerian added a subscriber: Mengerian.

I checked the parameters on mainnet and testnet, they are good.

In both cases defaultAssumeValid is unnecessarily far back from the chain tip, in future updates we could makes them closer to the tip.

src/chainparams.cpp
382 ↗(On Diff #1910)

Why are the block hashes not pre-pended with "0x" for Hex, like they are in all the other sections?

This revision is now accepted and ready to land.Dec 4 2017, 15:23
This revision was automatically updated to reflect the committed changes.