Update the chain paramaters.
ClosedPublic
Actions

Authored by deadalnix on Dec 2 2017, 01:08.

Details

Reviewers

schancel
Mengerian

Group Reviewers

Restricted Project

Commits

rSTAGING92361210ec28: Update the chain paramaters.
rABC92361210ec28: Update the chain paramaters.

Summary

As per title. Add the DAA activation as a checkpoint and update other parameters.

Test Plan

Do IBD for testnet and mainet.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 2 2017, 01:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2017, 01:08

Harbormaster completed remote builds in B1210: Diff 1887.Dec 2 2017, 01:08

rebase

Harbormaster completed remote builds in B1231: Diff 1910.Dec 3 2017, 16:59

schancel added inline comments.Dec 4 2017, 00:22

src/chainparams.cpp
140 ↗	(On Diff #1910)	I thought we wanted to do this after the fork date? This looks like it is before it.

freetrader added a subscriber: freetrader.Dec 4 2017, 03:31

freetrader added inline comments.

src/chainparams.cpp
250 ↗	(On Diff #1910)	We should come up with some Cash chain (post fork) data for this. It is used to estimate the progress afaik, and is quite outdated.

I checked the parameters on mainnet and testnet, they are good.

In both cases defaultAssumeValid is unnecessarily far back from the chain tip, in future updates we could makes them closer to the tip.

src/chainparams.cpp
382 ↗	(On Diff #1910)	Why are the block hashes not pre-pended with "0x" for Hex, like they are in all the other sections?

This revision is now accepted and ready to land.Dec 4 2017, 15:23

Closed by commit rABC92361210ec28: Update the chain paramaters. (authored by deadalnix). · Explain WhyDec 5 2017, 00:49

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

chainparams.cpp

35 lines

Diff 1931

View Options

Update the chain paramaters.ClosedPublicActions