Page MenuHomePhabricator

BCC -> BCH
ClosedPublic

Authored by jjz on Nov 10 2017, 02:48.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Maniphest Tasks
T110: Change BCC to BCH in the wallet
Commits
rSTAGINGc3f3212e16aa: BCC -> BCH
rABCc3f3212e16aa: BCC -> BCH
Summary

BCC -> BCH

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jjz created this revision.Nov 10 2017, 02:48
Owners added a reviewer: Restricted Owners Package.Nov 10 2017, 02:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2017, 02:48
freetrader added inline comments.
contrib/seeds/makeseeds.py
183 ↗(On Diff #1697)

BCC -> BCH

freetrader added a comment.EditedNov 10 2017, 04:00

Hi @jjz

I applied this diff to HEAD, and used a grep program to scan for more BCC. Found some which maybe you can still replace together with those you have already in this Diff:

src/wallet/test/wallet_tests.cpp
229: we should get 1 BCC in 1 coin
235:
we should get 2 BCC in 1 coin

src/rpc/mining.cpp
301:// NOTE: Unlike wallet RPC (which use BCC values), mining RPCs follow GBT (BIP
1005: "BCC)\n"

src/policy/fees.cpp
383: Feerates are stored and reported as BCC-per-kb:
411:
Feerates are stored and reported as BCC-per-kb:

src/test/rpc_tests.cpp
393: // BCC addresses should fail parsing

src/test/miner_tests.cpp
174: // 1BCC output.

src/qt/forms/coincontroldialog.ui
135: <string notr="true">0.00 BCC</string>
215: <string notr="true">0.00 BCC</string>
260: <string notr="true">0.00 BCC</string>
295: <string notr="true">0.00 BCC</string>

src/qt/forms/sendcoinsdialog.ui
327: <string notr="true">0.00 BCC</string>
407: <string notr="true">0.00 BCC</string>
458: <string notr="true">0.00 BCC</string>
487: <string notr="true">0.00 BCC</string>
1293: <string notr="true">123.456 BCC</string>

src/qt/forms/overviewpage.ui
132: <string notr="true">0.000 000 00 BCC</string>
157: <string notr="true">0.000 000 00 BCC</string>
182: <string notr="true">0.000 000 00 BCC</string>
240: <string notr="true">0.000 000 00 BCC</string>
285: <string notr="true">0.000 000 00 BCC</string>
310: <string notr="true">0.000 000 00 BCC</string>
352: <string notr="true">0.000 000 00 BCC</string>
377: <string notr="true">0.000 000 00 BCC</string>

src/qt/test/paymentservertests.cpp
200: // Payment request with amount overflow (amount is set to 21000001 BCC):

contrib/seeds/makeseeds.py
46: # All BCC clients apart BU and Classic has a space in the useragent string
183: # BCC chain will be consolidated.

freetrader requested changes to this revision.Nov 10 2017, 04:03

See previous comments for list of BCC occurrences that I think should be added.

This revision now requires changes to proceed.Nov 10 2017, 04:03
jjz added a comment.Nov 10 2017, 06:04

See previous comments for list of BCC occurrences that I think should be added.

ok! let me check again

jjz updated this revision to Diff 1698.Nov 10 2017, 07:38
jjz edited edge metadata.

update all files

jjz added a comment.Nov 10 2017, 07:51

See previous comments for list of BCC occurrences that I think should be added.

I have made this mistake , i have corrected it , thank you for your review

Thanks for doing this! Let me take a look.

schancel requested changes to this revision.Nov 10 2017, 08:28

Thanks @jjz. This looks good. I know you didn't originally add them, but can I ask you to please remove the autogenerated files and add them to the .gitignore?

doc/man/bitcoin-tx.1
6 ↗(On Diff #1698)

See below comment.

doc/man/bitcoind.1
6 ↗(On Diff #1698)

This file looks generated. Maybe it should be added to .gitignore?

@freetrader Do you know?

This revision now requires changes to proceed.Nov 10 2017, 08:28
jjz added a comment.Nov 10 2017, 08:50

Thanks @jjz. This looks good. I know you didn't originally add them, but can I ask you to please remove the autogenerated files and add them to the .gitignore?

This is an automated help document that does not require frequent updates , If ignore it , may be we forget to generate the doc . add this command (https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/contrib/devtools/README.md;a6d986485a2d03f6d8d311401e9360b71cf326fd$82) to the release process ,so you can ignore the generated documentation.

schancel accepted this revision.Nov 10 2017, 09:02

Okay, I'll fix it later.

deadalnix requested changes to this revision.Nov 10 2017, 11:58
deadalnix added a subscriber: deadalnix.

Except for the help file, this looks good. Please regenerate them to be non dirty and I'll accept.

doc/man/bitcoind.1
6 ↗(On Diff #1698)

No, but this hasn't be done properly as the dirty flag indicate.

Having everybody regenerating these files is not appropriate unless this can be somehow automated.

jjz updated this revision to Diff 1712.Nov 13 2017, 07:11
jjz edited edge metadata.

regenerate to be non dirty

jjz added a comment.Nov 13 2017, 07:15

Except for the help file, this looks good. Please regenerate them to be non dirty and I'll accept.

Hi @deadalnix I've got rid of the dirty , and I think it's best to run the command './gen-manpages.sh ' in the release version.

deadalnix accepted this revision.Nov 13 2017, 09:01
This revision is now accepted and ready to land.Nov 14 2017, 17:12
This revision was automatically updated to reflect the committed changes.