Page MenuHomePhabricator

OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change related OSX-specific handlers and Info.plist stuff to match.
ClosedPublic

Authored by CCulianu on Aug 30 2017, 15:41.

Details

Summary

Changed the OSX app bundle and Mac DMG file to be BitcoinABC-Qt.app and
Bitcoin-ABC.dmg respectively (old one was Core's Bitcoin-Qt.app and
Bitcoin.dmg)

Note this is a cosmetic change only and is verified to not break
settings which are still saved in
~/Library/Preferences/org.bitcoin.Bitcoin-Qt

I will write another PR.. err.. diff.. that will update the Qt App Name
and Org Name to be Bitcoin ABC -- and I will also write transition
"migration" code that will copy settings from old core
settings/registry/etc (cross platform location in this case) to our own
BitcoinABC location.

Test Plan

You need a mac. Or at least you need to cross-build for mac. If you need help on how to do this I can provide you with scripts.

make && make appbundle && make deploy. Verify name of app.

Also if you run it -- verify settings file is not changed. Verify all other names are ok.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

CCulianu created this revision.Aug 30 2017, 15:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 30 2017, 15:41
deadalnix edited edge metadata.Aug 30 2017, 16:51

This looks good, but we should really make sure that the gitian build works before merging.

Ok, I can do that at a later time (like later tonight or tomorrow morning) -- or freetrader -- if you're already set up mind doing it since.. well.. you're already set up?

freetrader edited edge metadata.Aug 30 2017, 19:04
In D510#8986, @CCulianu wrote:

Ok, I can do that at a later time (like later tonight or tomorrow morning) -- or freetrader -- if you're already set up mind doing it since.. well.. you're already set up?

No problem, sent you a download link for the OSX build products based on temporary testing branch at https://github.com/ftrader-bitcoinabc/bitcoin-abc/tree/d510_gitian_test

Aw man thanks a lot!

Yeah verified everything is 100% working. Looks good!

Thanks so much for doing it -- it saves me a ton of time to figure out gitian.

BTW when we release please let me CodeSign (Apple codesign) the binary. It would make us look more pro and it would stop warning messages from the OS about viruses and untrusted apps.

freetrader accepted this revision.Aug 30 2017, 21:07

Looks good, didn't find any other instances of Bitcoin-Qt that we want to change at this point
(there are some, but it's been noted that they affect the app id as far as Qt is concerned, and if we change them it will make the preferences files and Windows registry keys have a different unique id,
so users would lose their GUI preferences - these will be dealt with by migration code in further diff.

This revision is now accepted and ready to land.Aug 30 2017, 21:07
This revision was automatically updated to reflect the committed changes.