Fix proxy_test logging crash when no IPv6 available
ClosedPublic
Actions

Authored by freetrader on Aug 28 2017, 18:07.

Details

Reviewers

deadalnix
CCulianu

Group Reviewers

Restricted Project

Commits

rSTAGING7a0048edc78c: Fix proxy_test logging crash when no IPv6 available
rABC7a0048edc78c: Fix proxy_test logging crash when no IPv6 available

Summary

The test tried to use the self.log member in __init__()
but it is only set up in main() in BitcoinTestFramework.

This moves the calls into setup_nodes() which is called
by main, and should log correctly if IPv6 is not available.

Test Plan

qa/pull-tester/rpc-tests.py proxy_test

check that the test no longer fails on Travis

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

freetrader created this revision.Aug 28 2017, 18:07

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptAug 28 2017, 18:07

What is core doing here ?

Also prepend double space in front of the command lines in you test plan.

Yay! Good job! Simple fix, lol..

This revision is now accepted and ready to land.Aug 28 2017, 18:43

Ok this needs to stop. This is the second I'm asking a simple question that I think is key. What is core doing here ? Is it a problem for them and if not, what is their solution ?

This revision now requires changes to proceed.Aug 28 2017, 19:18

@deadalnix : after the T97 crash showed up on Travis, I compared the recent (0.15) Core proxy_test.py with ours, and indeed they applied the same fix by moving that code into setup_nodes().

freetrader edited the summary of this revision. (Show Details)Aug 28 2017, 19:48

freetrader edited the test plan for this revision. (Show Details)

I love how you panic, Deadalnix, without bothering to understand what is happening. :)

freetrader requested review of this revision.Aug 28 2017, 19:55

freetrader edited edge metadata.

CCulianu accepted this revision.Aug 28 2017, 20:30

deadalnix accepted this revision.Aug 28 2017, 21:37

This revision is now accepted and ready to land.Aug 28 2017, 21:37

Closed by commit rABC7a0048edc78c: Fix proxy_test logging crash when no IPv6 available (authored by freetrader, committed by freetrader). · Explain WhyAug 28 2017, 22:18

This revision was automatically updated to reflect the committed changes.