HomePhabricator

Fix proxy_test logging crash when no IPv6 available
7a0048edc78cUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Fix proxy_test logging crash when no IPv6 available

Summary:
The test tried to use the self.log member in __init__()
but it is only set up in main() in BitcoinTestFramework.

This moves the calls into setup_nodes() which is called
by main, and should log correctly if IPv6 is not available.

Test Plan:

qa/pull-tester/rpc-tests.py proxy_test

check that the test no longer fails on Travis

Reviewers: #bitcoin_abc, deadalnix, CCulianu

Reviewed By: #bitcoin_abc, deadalnix, CCulianu

Differential Revision: https://reviews.bitcoinabc.org/D504

Details

Provenance
freetraderAuthored on Aug 28 2017, 18:03
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Project
Differential Revision
D504: Fix proxy_test logging crash when no IPv6 available
Parents
rSTAGING42a837318e8c: Add SipHashUint256Extra as a specialization of siphash for a 256bits int and a…
Branches
Unknown
Tags
Unknown