As described
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGINGe8cacd37397a: Use std for make_pair in walletdb.cpp
rABCe8cacd37397a: Use std for make_pair in walletdb.cpp
make check
../qa/pull-tester/rpc-tests.py -extended
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- use_std_make_pair
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 607 Build 607: arc lint + arc unit
Event Timeline
Comment Actions
I think you are right that a search needs to be made.
Demangling the make_pair related symbols in src/wallet/libbitcoin_wallet_a-walletdb.o showed them as being std::make_pair (without this patch applied).
So they are coming from somewhere.
Comment Actions
After eliminating all occurrences of 'using namespace std', I found that make_pair still does not need to be qualified in this file, nor in others (e.g. net_processing.cpp).
This leaves only Boost as the source (ref. http://www.boost.org/doc/libs/1_46_1/doc/html/boost/proto/functional/make_pair.html).
If this patch were to be applied, there would be 8 instances of unqualified make_pair() use left over in the codebase, versus 134 qualified uses.
Since we want to move away from Boost, I think we should consistently apply the std:: qualifier to all make_pair() uses.