Page MenuHomePhabricator

Removed all using namespace std in wallet/
AbandonedPublic

Authored by deadalnix on Jul 29 2017, 19:18.

Details

Reviewers
AtlasShrugging
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

as stated

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/wallet/db.cpp:1CFMTCode style violation
Auto-Fixsrc/wallet/rpcdump.cpp:1CFMTCode style violation
Auto-Fixsrc/wallet/rpcwallet.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 612
Build 612: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jul 29 2017, 19:18

Reverted accidental CLion autofix

deadalnix requested changes to this revision.Jul 29 2017, 23:27
deadalnix added a subscriber: deadalnix.

It doesn't looks like what you wanted to diff.

This revision now requires changes to proceed.Jul 29 2017, 23:27

It doesn't looks like what you wanted to diff.

I did a diff update. If you expand to see the whole file it still has the other changes I made, but for some reason it's not showing that they've been changed. Probably because they were two separate commits. Don't know what I messed up.

There is only file changed in there.

Superceded by D428 - you can abandon this one.

Sorry, but I had to do it because I'm hunting down a bug in the course of which I'm working through eliminating using namespace std everywhere.

deadalnix abandoned this revision.
deadalnix edited reviewers, added: AtlasShrugging; removed: deadalnix.