Page MenuHomePhabricator
People darn-it-dan

darn-it-dan (Daniel Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2022, 03:55 (165 w, 6 d)

Recent Activity
View All

Jan 20 2022

darn-it-dan updated the diff for D10811: more comprehensive proptype validation for transaction components.

rebased from master

Jan 20 2022, 18:38
darn-it-dan abandoned D10856: upgrading webpack to latest and all it's dependencies.

sounds good,

Jan 20 2022, 17:33
darn-it-dan updated the test plan for D10856: upgrading webpack to latest and all it's dependencies.
Jan 20 2022, 16:59
darn-it-dan updated the test plan for D10856: upgrading webpack to latest and all it's dependencies.
Jan 20 2022, 16:59
darn-it-dan updated the summary of D10856: upgrading webpack to latest and all it's dependencies.
Jan 20 2022, 16:58
darn-it-dan requested review of D10856: upgrading webpack to latest and all it's dependencies.
Jan 20 2022, 16:56
darn-it-dan abandoned D10851: upgrading jest to latest.

did not create a new branch for this like a dumbass.

Jan 20 2022, 13:53
darn-it-dan updated the summary of D10851: upgrading jest to latest.
Jan 20 2022, 13:42
darn-it-dan requested review of D10851: upgrading jest to latest.
Jan 20 2022, 13:40
emack awarded D10809: added timezone constant for all npm tests a Doubloon token.
Jan 20 2022, 02:46
darn-it-dan updated the diff for D10811: more comprehensive proptype validation for transaction components.

changed opReturnMessage to string

Jan 20 2022, 02:25
darn-it-dan closed D10809: added timezone constant for all npm tests.
Jan 20 2022, 02:11
darn-it-dan committed rABCa0d16b267c32: added timezone constant for all npm tests (authored by darn-it-dan).
added timezone constant for all npm tests
Jan 20 2022, 02:11

Jan 19 2022

darn-it-dan abandoned D10826: fixed nested <a> error.
Jan 19 2022, 23:32
darn-it-dan abandoned D10794: (IGNORE FOR NOW, will be abandonded, keeping this up for refernece). fixing nested <a> tags in transactions.
Jan 19 2022, 19:24

Jan 14 2022

darn-it-dan updated the diff for D10826: fixed nested <a> error.

refactoring <TxHistory> to use the global theme prop

Jan 14 2022, 17:25
darn-it-dan added a comment to D10826: fixed nested <a> error.
In D10826#242914, @bytesofman wrote:

Does not preserve current user experience

"Reply to" feature still works, but now the user will also open a tx in explorer.be.cash in a new tab at the same time as redirecting cashtab to reply to a message

Jan 14 2022, 02:56
darn-it-dan added a comment to D10826: fixed nested <a> error.
In D10826#242914, @bytesofman wrote:

Does not preserve current user experience

"Reply to" feature still works, but now the user will also open a tx in explorer.be.cash in a new tab at the same time as redirecting cashtab to reply to a message

Jan 14 2022, 02:55
darn-it-dan updated the diff for D10826: fixed nested <a> error.

changed function to const, deleted un-needed htmlAttribute

Jan 14 2022, 02:55
darn-it-dan updated the diff for D10826: fixed nested <a> error.

Fixed UI behavior, reply button no longer opens explorer

Jan 14 2022, 02:51

Jan 13 2022

darn-it-dan retitled D10794: (IGNORE FOR NOW, will be abandonded, keeping this up for refernece). fixing nested <a> tags in transactions from fixing nested <a> tags in transactions to (IGNORE FOR NOW, will be abandonded, keeping this up for refernece). fixing nested <a> tags in transactions.
Jan 13 2022, 18:47
darn-it-dan requested review of D10826: fixed nested <a> error.
Jan 13 2022, 18:46

Jan 12 2022

darn-it-dan added a comment to D10809: added timezone constant for all npm tests.
In D10809#242756, @bytesofman wrote:

Will green this, pending contact on telegram to coordinate landing

Jan 12 2022, 02:10
darn-it-dan abandoned D10810: allow eslint to recongnize jest syntax.
Jan 12 2022, 02:09
darn-it-dan updated the diff for D10811: more comprehensive proptype validation for transaction components.

Deleted comments that are not needed in codebase

Jan 12 2022, 02:07
darn-it-dan added a comment to D10810: allow eslint to recongnize jest syntax.
In D10810#242749, @bytesofman wrote:

Parallel effort to fix this is underway here: https://reviews.bitcoinabc.org/D10770

Ultimate goal is to get ESLint to run as part of arc lint, so that a diff cannot get up with linting errors.

Let me know if there is a reason to include your overrides approach in addition to (or instead of) the approach taken in D10770 / any other improvements that could be made in D10770

Jan 12 2022, 00:04

Jan 11 2022

darn-it-dan requested review of D10811: more comprehensive proptype validation for transaction components.
Jan 11 2022, 04:05
darn-it-dan requested review of D10810: allow eslint to recongnize jest syntax.
Jan 11 2022, 03:50
darn-it-dan abandoned D10778: npm tests now run in UTC timezone.
Jan 11 2022, 03:42
darn-it-dan requested review of D10809: added timezone constant for all npm tests.
Jan 11 2022, 03:40

Jan 10 2022

darn-it-dan updated the summary of D10794: (IGNORE FOR NOW, will be abandonded, keeping this up for refernece). fixing nested <a> tags in transactions.
Jan 10 2022, 10:21
darn-it-dan updated the summary of D10794: (IGNORE FOR NOW, will be abandonded, keeping this up for refernece). fixing nested <a> tags in transactions.
Jan 10 2022, 10:16
darn-it-dan updated the diff for D10794: (IGNORE FOR NOW, will be abandonded, keeping this up for refernece). fixing nested <a> tags in transactions.

updating snapshots after linting changes

Jan 10 2022, 10:07
darn-it-dan requested review of D10794: (IGNORE FOR NOW, will be abandonded, keeping this up for refernece). fixing nested <a> tags in transactions.
Jan 10 2022, 10:05

Jan 8 2022

darn-it-dan updated the diff for D10778: npm tests now run in UTC timezone.

npm tests now run in UTC timezone

Jan 8 2022, 03:18
darn-it-dan updated the diff for D10778: npm tests now run in UTC timezone.

changed time env declaration to scripts/test.js

Jan 8 2022, 03:07

Jan 7 2022

darn-it-dan requested review of D10778: npm tests now run in UTC timezone.
Jan 7 2022, 04:53