Page MenuHomePhabricator

johnkuney (John)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 14 2020, 19:22 (234 w, 3 d)

Recent Activity

Yesterday

johnkuney closed D18066: [cashtab] Header UI overhaul.
Tue, May 13, 23:22
johnkuney committed rABC3870a0ac7d0b: [cashtab] Header UI overhaul (authored by johnkuney).
[cashtab] Header UI overhaul
Tue, May 13, 23:22
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

test edit

Tue, May 13, 21:41
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

version bump

Tue, May 13, 21:05
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

findbyText instead of findbyTitle

Tue, May 13, 18:18
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

increase timeout to 20000

Tue, May 13, 17:59
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

fix test value

Tue, May 13, 17:40
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

remove waitFor

Tue, May 13, 17:38
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

remove failed-test file, and remove waitFor from test, add increased timeout value to prevent timeout failures in tests

Tue, May 13, 17:34
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

test toubleshooting

Tue, May 13, 15:10
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

test troubleshooting

Tue, May 13, 14:30
johnkuney added a comment to D18066: [cashtab] Header UI overhaul.

Nice, for sure can get those in another diff.

Tue, May 13, 13:53
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

rebase

Tue, May 13, 04:18
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

fix tests and lint error

Tue, May 13, 04:16
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.
  • Remove zero balance messaging and just show 0.00 balance
  • Add links to XECX and Firma token pages
  • Remove color border
  • add horizontal scroll on mobile to reduce height
  • simplify style props
Tue, May 13, 03:52

Fri, May 9

johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

rebase

Fri, May 9, 20:54
johnkuney added a comment to D18066: [cashtab] Header UI overhaul.

also a fair point. Rome wasnt built in a day haha

Fri, May 9, 20:46
johnkuney added a comment to D18066: [cashtab] Header UI overhaul.

For sure, fair points. I believe its not necessarily much taller than the current UI if you do have an XECX and Firma balance, but that shouldnt be the benchmark.
I can try for a more compact solution, and possibly look at allowing users to dismiss the info text

Fri, May 9, 15:51
johnkuney published D18066: [cashtab] Header UI overhaul for review.
Fri, May 9, 04:43

Tue, Apr 29

johnkuney closed D18001: [cashtab] Mobile style fixes.
Tue, Apr 29, 16:47
johnkuney committed rABCfd87bb794a07: [cashtab] Mobile style fixes (authored by johnkuney).
[cashtab] Mobile style fixes
Tue, Apr 29, 16:47
johnkuney updated the diff for D18001: [cashtab] Mobile style fixes.

rebase

Tue, Apr 29, 16:46
johnkuney requested review of D18001: [cashtab] Mobile style fixes.

Re: the changes requested. It still has the word break applied if the name is long
That rule was to always word break that column in case of a long number amount

Tue, Apr 29, 15:31
johnkuney added a comment to D18001: [cashtab] Mobile style fixes.

alt approach would be to have a function prepareWrappedString that takes a string and maxChars as params, and returns the string truncated to maxChars

e.g. prepareWrappedString(tokenTickerThatIsTooLong, 10) = "tokenTi..." (keeps it to 10 chars max including the ellipsis)

Tue, Apr 29, 15:27
johnkuney updated the diff for D18001: [cashtab] Mobile style fixes.

dont word break last column on short names

Tue, Apr 29, 14:52
johnkuney updated the diff for D18001: [cashtab] Mobile style fixes.

dont word break on less than 10 length name or tickers, but do always word break in the amount column since it could be a big number

Tue, Apr 29, 01:53

Mon, Apr 28

johnkuney updated the diff for D18001: [cashtab] Mobile style fixes.

match styles with no token airdrop case

Mon, Apr 28, 21:43
johnkuney updated the diff for D18001: [cashtab] Mobile style fixes.

improve airdrop styles

Mon, Apr 28, 17:32

Sun, Apr 27

johnkuney updated the diff for D18001: [cashtab] Mobile style fixes.

put word break back

Sun, Apr 27, 17:00

Sat, Apr 26

johnkuney updated the diff for D18001: [cashtab] Mobile style fixes.

use stadard breakpoint, get icons back and line breaks back. Make icons much smaller and stack where needed

Sat, Apr 26, 17:08
teamcity awarded D18001: [cashtab] Mobile style fixes a Haypence token.
Sat, Apr 26, 13:27
johnkuney updated the test plan for D18001: [cashtab] Mobile style fixes.
Sat, Apr 26, 12:37
johnkuney updated the test plan for D18001: [cashtab] Mobile style fixes.
Sat, Apr 26, 12:32
johnkuney updated the test plan for D18001: [cashtab] Mobile style fixes.
Sat, Apr 26, 12:32
johnkuney requested review of D18001: [cashtab] Mobile style fixes.
Sat, Apr 26, 12:28

Fri, Apr 25

johnkuney committed rABCd40c68b72040: [cashtab] Transaction row UI (authored by johnkuney).
[cashtab] Transaction row UI
Fri, Apr 25, 17:41
johnkuney closed D17996: [cashtab] Transaction row UI.
Fri, Apr 25, 17:41
johnkuney added a comment to D17996: [cashtab] Transaction row UI.

for sure, reduced them a bit

Fri, Apr 25, 14:44
johnkuney updated the diff for D17996: [cashtab] Transaction row UI.

reduce margins

Fri, Apr 25, 14:43
johnkuney updated the test plan for D17996: [cashtab] Transaction row UI.
Fri, Apr 25, 14:22
johnkuney updated the test plan for D17996: [cashtab] Transaction row UI.
Fri, Apr 25, 14:19
teamcity awarded D17996: [cashtab] Transaction row UI a Haypence token.
Fri, Apr 25, 14:17
johnkuney added a comment to D17996: [cashtab] Transaction row UI.

Ah sure good point, will add screen caps and more description to test plan

Fri, Apr 25, 14:15
johnkuney updated the diff for D17996: [cashtab] Transaction row UI.

remove comment

Fri, Apr 25, 13:15
johnkuney requested review of D17996: [cashtab] Transaction row UI.
Fri, Apr 25, 13:12

Thu, Apr 24

johnkuney closed D17984: [cashtab] Move finalized indicator.
Thu, Apr 24, 17:55
johnkuney committed rABC0113f0b821a3: [cashtab] Move finalized indicator (authored by johnkuney).
[cashtab] Move finalized indicator
Thu, Apr 24, 17:55
johnkuney updated the diff for D17984: [cashtab] Move finalized indicator.

rebase

Thu, Apr 24, 14:09

Wed, Apr 23

johnkuney updated the diff for D17984: [cashtab] Move finalized indicator.

rebase

Wed, Apr 23, 19:53
johnkuney updated the diff for D17984: [cashtab] Move finalized indicator.

test build

Wed, Apr 23, 19:06
johnkuney updated the diff for D17984: [cashtab] Move finalized indicator.

fix test

Wed, Apr 23, 18:45
johnkuney requested review of D17984: [cashtab] Move finalized indicator.
Wed, Apr 23, 18:31

Thu, Apr 17

johnkuney closed D17941: [cashtab] CSS tweak for default desktop agora view.
Thu, Apr 17, 16:05
johnkuney committed rABC589bdef2aeb0: [cashtab] CSS tweak for default desktop agora view (authored by johnkuney).
[cashtab] CSS tweak for default desktop agora view
Thu, Apr 17, 16:05
johnkuney updated the diff for D17941: [cashtab] CSS tweak for default desktop agora view.

prop name edit

Thu, Apr 17, 16:05
johnkuney added a comment to D17941: [cashtab] CSS tweak for default desktop agora view.

ah sure, added

Thu, Apr 17, 15:22
johnkuney updated the diff for D17941: [cashtab] CSS tweak for default desktop agora view.

make the column logic more flexible for more whitelisted tokens

Thu, Apr 17, 15:18
johnkuney requested review of D17941: [cashtab] CSS tweak for default desktop agora view.
Thu, Apr 17, 02:04

Apr 2 2025

johnkuney accepted D17815: [Cashtab] Introduce CSS variables to make styling easier.

Please rebase before landing

Apr 2 2025, 14:57

Mar 27 2025

johnkuney added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 27 2025, 03:06

Mar 21 2025

johnkuney added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 21 2025, 14:28

Mar 20 2025

johnkuney requested changes to D17815: [Cashtab] Introduce CSS variables to make styling easier.

Good idea, but think theres some over complicating going on with the line heights

Mar 20 2025, 13:33

Mar 3 2025

johnkuney accepted D17720: [Cashtab] Show Firma on agora page.
Mar 3 2025, 00:23

Feb 28 2025

johnkuney accepted D17727: [mock-chronik-client] Major version bump for new chronik-client types.
Feb 28 2025, 18:28

Jan 25 2025

johnkuney closed D17588: [cashtab] Token view UI updates.
Jan 25 2025, 03:47
johnkuney committed rABCc69e484a47e0: [cashtab] Token view UI updates (authored by johnkuney).
[cashtab] Token view UI updates
Jan 25 2025, 03:47

Jan 24 2025

johnkuney updated the diff for D17588: [cashtab] Token view UI updates.

delete balancetokenheader component as no longer used anywhere

Jan 24 2025, 23:07
johnkuney published D17588: [cashtab] Token view UI updates for review.
Jan 24 2025, 19:05
johnkuney abandoned D17584: [cashtab] Token view UI updates.
Jan 24 2025, 17:37
johnkuney planned changes to D17584: [cashtab] Token view UI updates.
Jan 24 2025, 00:40

Jan 23 2025

johnkuney updated the diff for D17584: [cashtab] Token view UI updates.

fix errors

Jan 23 2025, 22:21
johnkuney planned changes to D17584: [cashtab] Token view UI updates.
Jan 23 2025, 22:16
johnkuney accepted D17583: [e.cash] Add a link to the chronik documentation.
Jan 23 2025, 22:15
johnkuney requested review of D17584: [cashtab] Token view UI updates.
Jan 23 2025, 22:07

Jan 11 2025

johnkuney accepted D17511: [Cashtab] Make agora screen more polite.
Jan 11 2025, 07:01
johnkuney accepted D17508: [Cashtab] Do not load ALL agora offers unless the user asks for it.

Cool, works for me and is good interim solution. The polite loading is nice
Only suggestion is move the button below the initial listings for subjective reasons

Jan 11 2025, 07:01

Jan 10 2025

johnkuney accepted D17510: [Cashtab] Hide sort switches on mange my offers option as they do not work there.
Jan 10 2025, 23:24
johnkuney closed D17502: [cashtab] Agora UI updates.
Jan 10 2025, 22:54
johnkuney committed rABC27e92083c795: [cashtab] Agora UI updates (authored by johnkuney).
[cashtab] Agora UI updates
Jan 10 2025, 22:54
johnkuney added a comment to D17502: [cashtab] Agora UI updates.

Cool, added

Jan 10 2025, 22:27
johnkuney updated the diff for D17502: [cashtab] Agora UI updates.

remove css class and make it a styled component

Jan 10 2025, 22:26
johnkuney updated the diff for D17502: [cashtab] Agora UI updates.

rebase

Jan 10 2025, 18:47
johnkuney updated the summary of D17502: [cashtab] Agora UI updates.
Jan 10 2025, 15:30
johnkuney published D17502: [cashtab] Agora UI updates for review.
Jan 10 2025, 15:29

Jan 6 2025

johnkuney accepted D17480: [ecash-herald] Move to agora-indexed chronik.
Jan 6 2025, 23:30

Jan 3 2025

johnkuney committed rABC3b6dd3e26a3e: [e.cash] Add Swapspace widget (authored by johnkuney).
[e.cash] Add Swapspace widget
Jan 3 2025, 00:55
johnkuney closed D17439: [e.cash] Add Swapspace widget.
Jan 3 2025, 00:55

Jan 2 2025

teamcity awarded D17439: [e.cash] Add Swapspace widget a Doubloon token.
Jan 2 2025, 21:17
johnkuney added a comment to D17439: [e.cash] Add Swapspace widget.

Okay how about this? fyi those styles on swapspace are what they have in their instructions for the widget

Jan 2 2025, 21:07
johnkuney updated the diff for D17439: [e.cash] Add Swapspace widget.

dont show side by side, copy edit

Jan 2 2025, 21:05

Dec 31 2024

teamcity awarded D17439: [e.cash] Add Swapspace widget a Piece of Eight token.
Dec 31 2024, 19:36
johnkuney added a comment to D17439: [e.cash] Add Swapspace widget.

hmm I wasn't able to target the iframe scrollbars afaict. Thats weird yours are looking like that though, mine have the custom scrollbar styles
How does the widget look for you on this page https://swapzone.io/partners/exchange-widget ?

Dec 31 2024, 18:34
johnkuney updated the diff for D17439: [e.cash] Add Swapspace widget.

fix copy

Dec 31 2024, 18:31
teamcity awarded D17439: [e.cash] Add Swapspace widget a Haypence token.
Dec 31 2024, 06:19
johnkuney requested review of D17439: [e.cash] Add Swapspace widget.
Dec 31 2024, 04:31

Dec 18 2024

johnkuney accepted D17369: [mock-chronik-client] Add support for Agora ws subscriptions.
Dec 18 2024, 21:42

Dec 11 2024

johnkuney closed D17334: [e.cash] Add openInNewTab prop to /use-ecash buttons.
Dec 11 2024, 05:19
johnkuney committed rABC931c83b45e5a: [e.cash] Add openInNewTab prop to /use-ecash buttons (authored by johnkuney).
[e.cash] Add openInNewTab prop to /use-ecash buttons
Dec 11 2024, 05:19
johnkuney requested review of D17334: [e.cash] Add openInNewTab prop to /use-ecash buttons.
Dec 11 2024, 04:35

Dec 6 2024

johnkuney closed D17307: [e.cash] Better handle price api response.
Dec 6 2024, 20:07