Page MenuHomePhabricator
Differential D18001

[cashtab] Mobile style fixes
Needs ReviewPublic
Actions

Authored by johnkuney on Sat, Apr 26, 12:27.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Fixing some display issues on smaller screens on the transaction rows

Test Plan

Preview the site and check transactions, especially token info and messages, look good on small screens

after

before_.png (1×1 px, 224 KB)

before

after_.png (1×1 px, 211 KB)

Things to note:
Losing the tx icon and token image/icon at very small screens to allow other content to fit nicer
margins and padding tightened up

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-mobile-tx-row-style-fixes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33119
Build 65722: Build Diffcashtab-tests
Build 65721: arc lint + arc unit

Event Timeline

johnkuney created this revision.Sat, Apr 26, 12:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Apr 26, 12:27
johnkuney requested review of this revision.Sat, Apr 26, 12:27
johnkuney edited the test plan for this revision. (Show Details)Sat, Apr 26, 12:32
johnkuney edited the test plan for this revision. (Show Details)
johnkuney edited the test plan for this revision. (Show Details)Sat, Apr 26, 12:37
Harbormaster completed remote builds in B33117: Diff 53709.Sat, Apr 26, 12:53
Fabien added a subscriber: Fabien.Sat, Apr 26, 13:27

@bot preview-cashtab

teamcity awarded a token.Sat, Apr 26, 13:27
teamcity added a comment.Sat, Apr 26, 13:30

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.68.37.192:41958 for the next 60 minutes.

bytesofman requested changes to this revision.Sat, Apr 26, 13:41
bytesofman added a subscriber: bytesofman.
bytesofman added inline comments.
cashtab/src/components/Home/Tx/styled.ts
264–266 ↗(On Diff #53709)

I don't think we can just lose these -- the issue is a cashtab msg can include, say, a txid or an ecash address, and without break-all this just bonks the whole display

303 ↗(On Diff #53709)

is 500px where we start to see issues?

would be nice to not lose the icons, they do distinguish between a wide range of tx types.

can we just make them smaller?

This revision now requires changes to proceed.Sat, Apr 26, 13:41
johnkuney updated this revision to Diff 53711.Sat, Apr 26, 17:08
johnkuney edited the test plan for this revision. (Show Details)

use stadard breakpoint, get icons back and line breaks back. Make icons much smaller and stack where needed

Harbormaster completed remote builds in B33119: Diff 53711.Sat, Apr 26, 17:13

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Home/
1 line
Tx/
70 lines

Diff 53711

View Options

cashtab/src/components/Home/Home.tsx

Loading...
View Options

cashtab/src/components/Home/Tx/styled.ts

Loading...