Fixing some display issues on smaller screens on the transaction rows
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
Preview the site and check transactions, especially token info and messages, look good on small screens
after
before
Things to note:
Losing the tx icon and token image/icon at very small screens to allow other content to fit nicer
margins and padding tightened up
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cashtab-mobile-tx-row-style-fixes
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 33117 Build 65718: Build Diff cashtab-tests Build 65717: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.68.37.192:41958 for the next 60 minutes.
| cashtab/src/components/Home/Tx/styled.ts | ||
|---|---|---|
| 264–266 | I don't think we can just lose these -- the issue is a cashtab msg can include, say, a txid or an ecash address, and without break-all this just bonks the whole display | |
| 303 | is 500px where we start to see issues? would be nice to not lose the icons, they do distinguish between a wide range of tx types. can we just make them smaller? | |
Comment Actions
use stadard breakpoint, get icons back and line breaks back. Make icons much smaller and stack where needed
| cashtab/src/components/Home/Tx/styled.ts | ||
|---|---|---|
| 231 ↗ | (On Diff #53711) | can we really lose this? none of these break-alls appeared spontaneously; it's always something that is added bc there is some hideous css bug where a long string overflows the whole screen |