HomePhabricator

[avalanche] Fix flaky loops in abc_p2p_compactproofs

Description

[avalanche] Fix flaky loops in abc_p2p_compactproofs

Summary:
There is a couple places where the test loops over mockscheduler and waits for an event. However it might occur that the mockscheduler RPC call is exectuted before the process is being rescheduled, which makes it a no op and fails the test.
Since the loops are arbitrary in this test and do not increase coverage, this diff gets rid of the potential issue by removing them. This has the added benefit of speeding up the test slightly.

Test Plan:

for i in {1..20}; do ./test/functional/test_runner.py abc_p2p_compactproofs || break; done

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D11817

Details

Provenance
FabienAuthored on Jul 29 2022, 16:11
FabienPushed on Jul 29 2022, 19:10
Reviewer
Restricted Project
Differential Revision
D11817: [avalanche] Fix flaky loops in abc_p2p_compactproofs
Parents
rABCc948c127e1e9: [avalanche] Fix flaky check for finalized proofs in abc_rpc_getavalancheinfo
Branches
Unknown
Tags
Unknown