HomePhabricator

net: Remove g_relay_txes

Description

net: Remove g_relay_txes

Summary:

g_relay_txes is only required inside net_processing and is set only once at startup. Instead of having a global, move it to be a const member of PeerManager.

This requires moving PushNodeVersion() into PeerManager, which also allows us to remove the connman argument.

Backport of core#20217.

Ref T1696.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Maniphest Tasks: T1696

Differential Revision: https://reviews.bitcoinabc.org/D10884

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Oct 22 2020, 09:53
FabienCommitted on Jan 25 2022, 13:01
FabienPushed on Jan 25 2022, 13:01
Reviewer
Restricted Project
Differential Revision
D10884: net: Remove g_relay_txes
Parents
rABCa5142b422d00: net, net_processing: move NetEventsInterface method docs to net.h
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task

Event Timeline

Fabien committed rABC042e6fa41ef0: net: Remove g_relay_txes (authored by John Newbery <john@johnnewbery.com>).Jan 25 2022, 13:01
Fabien added a task: Restricted Maniphest Task.