HomePhabricator

[qa] Fix sync_blocks timeout argument

Description

[qa] Fix sync_blocks timeout argument

Motivation for this change is mainly to make sync_blocks behavior easier to
understand. Behavior is unchanged in the normal case when there are only 2
nodes in the rpc_connections set. When there are more than 2 nodes, the
previous "timeout -= wait" statement wouldn't take into account time spent
waiting for all nodes and as a result could lead to blocking for longer than
the requested timeout.

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Nov 11 2016, 20:40
deadalnixPushed on May 14 2017, 22:04
Parents
rABCfd6bb700b774: [qa] Improve sync_blocks error messages.
Branches
Unknown
Tags
Unknown

Event Timeline

Russell Yanofsky <russ@yanofsky.org> committed rABC05e57ccd746b: [qa] Fix sync_blocks timeout argument (authored by Russell Yanofsky <russ@yanofsky.org>).Nov 14 2016, 17:02