HomePhabricator

[avalanche] Fix conflict time initializer to zero

Description

[avalanche] Fix conflict time initializer to zero

Summary:
std::chrono::duration's default constructor does not initialize to zero. See rationale by the author here: https://groups.google.com/a/isocpp.org/g/std-discussion/c/OcGX7Yj3meI

We saw this break during live testing. A followup patch will include a linter so this issue does not occur in the future.

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11759

Details

Provenance
sdulfariAuthored on Jul 15 2022, 18:59
sdulfariPushed on Jul 15 2022, 21:12
Reviewer
Restricted Project
Differential Revision
D11759: [avalanche] Fix conflict time initializer to zero
Parents
rABCbed6b713220c: [avalanche] Improve RPC fields names and description in getavalanchepeerinfo
Branches
Unknown
Tags
Unknown