Differential D11759

[avalanche] Fix conflict time initializer to zero
ClosedPublic
Actions

Authored by sdulfari on Jul 15 2022, 19:06.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0ba75da2ed39: [avalanche] Fix conflict time initializer to zero

Summary

std::chrono::duration's default constructor does not initialize to zero. See rationale by the author here: https://groups.google.com/a/isocpp.org/g/std-discussion/c/OcGX7Yj3meI

We saw this break during live testing. A followup patch will include a linter so this issue does not occur in the future.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Jul 15 2022, 19:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2022, 19:06

sdulfari requested review of this revision.Jul 15 2022, 19:06

Fabien accepted this revision.Jul 15 2022, 19:09

This revision is now accepted and ready to land.Jul 15 2022, 19:09

Harbormaster completed remote builds in B19652: Diff 34401.Jul 15 2022, 19:23

Closed by commit rABC0ba75da2ed39: [avalanche] Fix conflict time initializer to zero (authored by sdulfari). · Explain WhyJul 15 2022, 21:12

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC0ba75da2ed39: [avalanche] Fix conflict time initializer to zero.

sdulfari added a reverting change: D11760: Add linter to ensure chrono::duration is always initialized.Jul 16 2022, 03:33

sdulfari added a reverting change: rABC7da1378306f6: Add linter to ensure chrono::duration is always initialized.Jul 18 2022, 16:10

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

2 lines

Diff 34403

View Options

src/avalanche/peermanager.cpp

[avalanche] Fix conflict time initializer to zeroClosedPublicActions