Page MenuHomePhabricator
Differential D11760

Add linter to ensure chrono::duration is always initialized
ClosedPublic
Actions

Authored by sdulfari on Jul 16 2022, 03:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7da1378306f6: Add linter to ensure chrono::duration is always initialized
Summary

Follow up to D11759. This avoids accidentially leaving chrono::duration uninitialized which can lead to unexpected behavior.
A reasonable default of 0 has been picked.

Test Plan

Revert D11759, then arc lint

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sdulfari created this revision.Jul 16 2022, 03:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2022, 03:33
sdulfari requested review of this revision.Jul 16 2022, 03:33
Harbormaster completed remote builds in B19653: Diff 34404.Jul 16 2022, 03:33
Fabien accepted this revision.Jul 16 2022, 15:03
Fabien added a subscriber: Fabien.
Fabien added inline comments.
.arclint
141 ↗(On Diff #34404)

no need for c files

This revision is now accepted and ready to land.Jul 16 2022, 15:03
Closed by commit rABC7da1378306f6: Add linter to ensure chrono::duration is always initialized (authored by sdulfari). · Explain WhyJul 18 2022, 16:10
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC7da1378306f6: Add linter to ensure chrono::duration is always initialized.

Revision Contents
Changeset List

PathSize
4 lines
arcanist/
linter/
60 lines

Diff 34407

View Options

.arclint

Loading...
View Options

arcanist/__phutil_library_map__.php

Loading...
View Options

arcanist/linter/StdChronoLinter.php

Loading...